Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: includeDependencies not working as expected #1264

Open
dsaveyn opened this issue Oct 15, 2024 · 3 comments
Open

[Bug]: includeDependencies not working as expected #1264

dsaveyn opened this issue Oct 15, 2024 · 3 comments
Assignees
Labels
bug Something isn't working Under Investigation Issue is under investigation

Comments

@dsaveyn
Copy link

dsaveyn commented Oct 15, 2024

AL-Go version

6.0

Describe the issue

We have setup a project with the following settings:

"includeDependencies": [
  "Dynavision*.app",
  "ESC*.app"
]

But when we look at the release artifacts, the Continia artifacts are also included:

"includeDependencies": [
  "Dynavision*.app",
  "ESC*.app"
]

Expected behavior

The Continia artifacts should be taken from the AppSource Catalog

Steps to reproduce

/

Additional context (logs, screenshots, etc.)

logs_29638379195.zip

@dsaveyn dsaveyn added the bug Something isn't working label Oct 15, 2024
@freddydk
Copy link
Contributor

freddydk commented Oct 17, 2024

IncludeDependencies is a property of the DeliverToAppSource setting (see https://aka.ms/algosettings#delivertoappsource) and only determines which apps are included when delivering to AppSource.

It looks like you are trying something different here?

Could you explain your scenario and what you are trying to achieve?

@freddydk freddydk added the Need more info Please add more info about how to repro the problem label Oct 17, 2024
@dsaveyn
Copy link
Author

dsaveyn commented Oct 17, 2024

Our app has 3 dependencies: a Dynavision app, an ESC app and the Continia Document Capture app. When we deliver the app to AppSource, the validation fails with the message that the Continia app files are not signed (no idea why exactly, I would expect them to be signed).

The AppSource submission contains 2 files: The main app file and a zip file containing the library apps: the Dynavision app, the ESC app and all Continia Document Capture apps. So for some reason the Continia Document Capture apps are still included in the library zip despite the filters specified in includeDependencies:

Image

@freddydk
Copy link
Contributor

Got it - will have a look.

@freddydk freddydk self-assigned this Oct 17, 2024
@freddydk freddydk added Under Investigation Issue is under investigation and removed Need more info Please add more info about how to repro the problem labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Under Investigation Issue is under investigation
Projects
None yet
Development

No branches or pull requests

2 participants