Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Support for Preprocessor Symbols in AL-GO Workflows for NextMinor/NextMajor Builds #1358

Open
ivandjordjevic opened this issue Dec 12, 2024 · 10 comments
Labels
question Further information is requested

Comments

@ivandjordjevic
Copy link

Question

Does the current AL-GO workflow support producing NextMinor and NextMajor artifacts built from the main branch with specific preprocessor symbols for each release? For instance, we’d like to trigger conditional code blocks specific to these builds only and publish those as separate artifacts.

#if NEXTMAJOR
Message('Hello NEXTMAJOR feature!')
#endif

We aim to include conditional logic in the main branch that is only activated for NextMinor or NextMajor builds using preprocessor symbols like NEXTMAJOR, NEXTMINOR, CLEAN25, CLEAN26, etc.

@ivandjordjevic ivandjordjevic added the question Further information is requested label Dec 12, 2024
@ivandjordjevic
Copy link
Author

Hi @freddydk, appreciate your insights on this.

I was hoping that also Test Next Major.settings.json file would support a property for preprocessorSymbols to support this such as:

"preprocessorSymbols": [
        "NEXTMAJOR"
    ]

@freddydk
Copy link
Contributor

@mazhelez - can they use BuildModes for this?
Or is cleanModePreprocessorSymbols hardcoded for buildmode = cleanMode only?

@mazhelez
Copy link
Collaborator

cleanModePreprocessorSymbols setting is currently only used in the "clean" build mode.

But artifacts are not output for the different build modes, but the default one.

@ivandjordjevic
Copy link
Author

@mazhelez @freddydk What's the best way to approach this? We used PreprocessorSymbols in our custom Azure DevOps CICD to build different versions from the same codebase and MSFT uses it in the base app as well:
Image

@freddydk
Copy link
Contributor

I guess the request here is:

  1. Add the ability to define preprocessorsymbols when running Test NextMajor, Test NextMinor and Test Current workflows.
  2. Produce build artifacts in these workflows (like CI/CD)

Is this what you are looking for?

@ivandjordjevic
Copy link
Author

@freddydk - Correct, that will work!

@ivandjordjevic
Copy link
Author

Is this something we will be able to follow on the Roadmap?

I interested in the timeline, if and when will this be available.

@freddydk
Copy link
Contributor

freddydk commented Dec 19, 2024 via email

@ivandjordjevic
Copy link
Author

Can you share the card so we can follow?

@freddydk
Copy link
Contributor

https://github.com/orgs/microsoft/projects/521/views/1?pane=issue&itemId=91449371 - a little strange heading, but this is because this workitem will solve some other issues as well (together with this problem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants