Unable to return succes for feedback

[PauwelsYoran]

Hi,
I am trying to implement the feedback feature for our teams agents that we created in .net. (https://learn.microsoft.com/en-us/microsoftteams/platform/teams-ai-library/csharp/in-depth-guides/feedback)

We were able to catch the event by creating an agent based on Agent appplication and then triggering the invoke activity.

public class TeamsAgent : AgentApplication

OnActivity(ActivityTypes.Invoke, HandleInvoke, rank: RouteRank.Last);

The function to handle the feedback then returns a Task.completed task

protected async Task<Task> HandleInvoke(ITurnContext turnContext, ITurnState turnState, CancellationToken cancellationToken)
{
    var a = turnContext;
    await turnContext.SendActivityAsync(new Activity { Type = ActivityTypes.Typing });
    return Task.CompletedTask;
}

So the invoke works and I can process the data, but in teams user get this message:

When using the teams browser the http invoke call returns the following json

{
    "errorCode": 1008,
    "message": "<BotError>Agent returned unsuccessful status code NotImplemented",
    "standardizedError": {
        "errorCode": 1008,
        "errorSubCode": 1,
        "errorDescription": "<BotError>Agent returned unsuccessful status code NotImplemented"
    }
}

How can properly close the feedback screen without the warning?

[tracyboehrer]

@PauwelsYoran Have you tried using the Teams Extension (Microsoft.Agents.Extensions.Teams)? You can do it the way you are though.

For any Invoke type request, the expectation from the caller is that an InvokeResponse is returned. I suspect that will at least be part of the problem. The easiest way to do that is instead of sending a Typing activity, do:

var activity = Activity.CreateInvokeResponseActivity();
await turnContext.SendActivityAsync(activity, cancellationToken);

The TeamsExtension wraps this up in a nicer package. There are other advantages to using the extension as well. For example, there are a lot of different Invoke requests. The extension will restrict this to just FeedbackLoop requests, as well as automatically send the InvokeResponse.

public class TeamsAgent : AgentApplication
{
    public TeamsAgent(AgentApplicationOptions options) : base(options)
    {
        RegisterExtension(new TeamsAgentExtension(this), tae =>
        {
            tae.OnFeedbackLoop(MyFeedbackLoopHandler);
        });

        // add other Activity routes here if needed.
    }

    private Task MyFeedbackLoopHandler(ITurnContext turnContext, ITurnState turnState, FeedbackLoopData feedbackLoopData, CancellationToken cancellationToken)
    {
        // Do something with FeedbackLoopData
        return Task.CompletedTask;
    }
}

[PauwelsYoran]

Hi @tracyboehrer ,

I was able to do it using the TeamsExtension. However i did notice the feedback function can't be async.
Is there a way to keep the function async, since i want to create a workitem in devops using the api?

[tracyboehrer]

@PauwelsYoran I don't know of a reason why it couldn't be async. Just add the async keyword before Task and await away.

[PauwelsYoran]

@tracyboehrer , I tested it using async and I can get it to work.
But it still seems to be that the submit screen waits for like 10-20 seconds, if it by then hasn't received a response, it still displays the error.
I assume this "time-out" is by design?

[tracyboehrer]

@PauwelsYoran Teams has some strict time limits on Invokes in most cases. How long is your response taking?

[PauwelsYoran]

@tracyboehrer I am still working on it since I need to retrieve some extra data from the graph api.
Right now it is taking longer because I am testing locally and retrieving the DefaultAzure credentials always takes a while.
It is possible I will get it to work within the timframe. Otherwise I will let the function run synchronously and create the item in the background without keeping the user waiting.

[sarahcritchley]

Did you get it working @PauwelsYoran ?

[PauwelsYoran]

@sarahcritchley we got i to work by not making the function run async. In there we call an async function but do not await it.
That way the users do not get the error and we handle the saving in the background.
We were able to get it to run async but the timings were to close so sometimes it would work, sometimes it would give an error.

[sarahcritchley]

@PauwelsYoran it looks like this is from the time out for Invokes in teams unfortunately - let me know if you want me to surface this to the teams group for review as well.