Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for all color camera parameters in k4arecorder #1722

Open
borosko opened this issue Dec 30, 2021 · 2 comments · May be fixed by #1757
Open

Support for all color camera parameters in k4arecorder #1722

borosko opened this issue Dec 30, 2021 · 2 comments · May be fixed by #1757
Assignees
@dasparli
Labels
Enhancement New feature or request Triage Approved The Issue has been approved by an Azure Kinect team member.

Comments

@borosko
Copy link

borosko commented Dec 30, 2021

Is your feature request related to a problem? Please describe.
k4arecorder not able to set color camera parameters

Describe the solution you'd like
k4arecorder supports setting color camera parameters, specifically whiteBalance, brightness, contrast, saturation, sharpness.

Describe alternatives you've considered
A workaround is to set these parameters manually from k4aviewer, but this poses a significant strain and is very error prone when trying to reproduce recordings of similar quality.

Additional context
This is already implemented in https://github.com/borosko/Azure-Kinect-Sensor-SDK fork. I'm creating this issue to be triaged so I can create a PullRequest.
My team has been using this build successfully for the past 6 months. We've been replacing the default 1.4.1 k4arecorder using this msi: https://github.com/borosko/Azure-Kinect-Sensor-SDK/releases/tag/coloropt
@borosko borosko added Enhancement New feature or request Triage Needed The Issue still needs to be reviewed by Azure Kinect team members. labels Dec 30, 2021
@qm13 qm13 removed the Triage Needed The Issue still needs to be reviewed by Azure Kinect team members. label Jan 3, 2022
@qm13 qm13 self-assigned this Jan 7, 2022
@borosko
Copy link
Author

borosko commented Mar 11, 2022

This is not getting any traction for 3+ months. Is there anything I should do here? I have prepared a PR, but just waiting for an issue to be approved to be able to create it. @qm13

@qm13 qm13 added the Triage Approved The Issue has been approved by an Azure Kinect team member. label Mar 11, 2022
@qm13
Copy link
Collaborator

qm13 commented Mar 11, 2022

@borosko please go ahead and create a PR.

@borosko borosko linked a pull request Mar 21, 2022 that will close this issue
Open
7 tasks
@qm13 qm13 assigned qm13 and dasparli and unassigned qm13 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dasparli dasparli

Labels
Enhancement New feature or request Triage Approved The Issue has been approved by an Azure Kinect team member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for all color camera parameters in k4arecorder borosko/Azure-Kinect-Sensor-SDK
3 participants
@qm13 @borosko @dasparli