From 67f44f053b556956e4ad2fb04bacb6d7d21b2072 Mon Sep 17 00:00:00 2001 From: Shane Ferrell Date: Thu, 3 Aug 2023 11:34:04 -0700 Subject: [PATCH 1/6] Add Teams warning --- Calendar/Get-RBASummary.ps1 | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Calendar/Get-RBASummary.ps1 b/Calendar/Get-RBASummary.ps1 index 9d63b1f7c1..eb5f1457a8 100644 --- a/Calendar/Get-RBASummary.ps1 +++ b/Calendar/Get-RBASummary.ps1 @@ -361,6 +361,11 @@ function RBAPostProcessing { `t EnableAutoRelease: $($RbaSettings.EnableAutoRelease) `t AddAdditionalResponse: $($RbaSettings.AddAdditionalResponse) "@ + +# Warnings: + if ($RbaSettings.DeleteComments -eq $true) { + write-host -ForegroundColor Yellow "Warning: DeleteComments is set to true. This will remove the Teams information which is in the meeting body." + } } # RBA Verbose PostProcessing Steps From 66f25a8465ec47203e2869df3ed3a7600cb0263c Mon Sep 17 00:00:00 2001 From: Shane Ferrell Date: Thu, 3 Aug 2023 11:43:04 -0700 Subject: [PATCH 2/6] Add Teams Warning --- Calendar/Get-RBASummary.ps1 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Calendar/Get-RBASummary.ps1 b/Calendar/Get-RBASummary.ps1 index eb5f1457a8..94bf359b13 100644 --- a/Calendar/Get-RBASummary.ps1 +++ b/Calendar/Get-RBASummary.ps1 @@ -310,6 +310,7 @@ function RBADelegateSettings { Write-Host "`t ForwardRequestsToDelegates: "$RbaSettings.ForwardRequestsToDelegates Write-Host +# Warnings: if ($RbaSettings.ResourceDelegates.Count -gt 0) { if ($RbaSettings.AddNewRequestsTentatively -eq $true) { Write-Host "In-policy meetings will be marked tentative and the meeting request will be sent to the Resource Delegates to be accepted or rejected. Default" @@ -364,7 +365,7 @@ function RBAPostProcessing { # Warnings: if ($RbaSettings.DeleteComments -eq $true) { - write-host -ForegroundColor Yellow "Warning: DeleteComments is set to true. This will remove the Teams information which is in the meeting body." + Write-Host -ForegroundColor Yellow "Warning: DeleteComments is set to true. This will remove the Teams information which is in the meeting body." } } From 0cfe6747fea64ed4e9e5fb3cda01567ee87fb661 Mon Sep 17 00:00:00 2001 From: Shane Ferrell Date: Thu, 3 Aug 2023 12:08:47 -0700 Subject: [PATCH 3/6] CodeFormatting... --- Calendar/Get-RBASummary.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Calendar/Get-RBASummary.ps1 b/Calendar/Get-RBASummary.ps1 index 94bf359b13..45a9a374fb 100644 --- a/Calendar/Get-RBASummary.ps1 +++ b/Calendar/Get-RBASummary.ps1 @@ -310,7 +310,7 @@ function RBADelegateSettings { Write-Host "`t ForwardRequestsToDelegates: "$RbaSettings.ForwardRequestsToDelegates Write-Host -# Warnings: + # Warnings: if ($RbaSettings.ResourceDelegates.Count -gt 0) { if ($RbaSettings.AddNewRequestsTentatively -eq $true) { Write-Host "In-policy meetings will be marked tentative and the meeting request will be sent to the Resource Delegates to be accepted or rejected. Default" @@ -363,7 +363,7 @@ function RBAPostProcessing { `t AddAdditionalResponse: $($RbaSettings.AddAdditionalResponse) "@ -# Warnings: + # Warnings: if ($RbaSettings.DeleteComments -eq $true) { Write-Host -ForegroundColor Yellow "Warning: DeleteComments is set to true. This will remove the Teams information which is in the meeting body." } From cb02de3ca3ba0d8df9f507dec27ccf9c7db9489d Mon Sep 17 00:00:00 2001 From: Shane Ferrell Date: Thu, 3 Aug 2023 16:54:41 -0700 Subject: [PATCH 4/6] Update comments --- Calendar/Get-RBASummary.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Calendar/Get-RBASummary.ps1 b/Calendar/Get-RBASummary.ps1 index 45a9a374fb..a8d7b34575 100644 --- a/Calendar/Get-RBASummary.ps1 +++ b/Calendar/Get-RBASummary.ps1 @@ -310,7 +310,7 @@ function RBADelegateSettings { Write-Host "`t ForwardRequestsToDelegates: "$RbaSettings.ForwardRequestsToDelegates Write-Host - # Warnings: + # Check for know configuration issues to warn about: if ($RbaSettings.ResourceDelegates.Count -gt 0) { if ($RbaSettings.AddNewRequestsTentatively -eq $true) { Write-Host "In-policy meetings will be marked tentative and the meeting request will be sent to the Resource Delegates to be accepted or rejected. Default" @@ -363,7 +363,7 @@ function RBAPostProcessing { `t AddAdditionalResponse: $($RbaSettings.AddAdditionalResponse) "@ - # Warnings: + # Warning about the DeleteComments setting and Teams: if ($RbaSettings.DeleteComments -eq $true) { Write-Host -ForegroundColor Yellow "Warning: DeleteComments is set to true. This will remove the Teams information which is in the meeting body." } From e9eeab92524e73fa7be31d45cf049535ee0f278d Mon Sep 17 00:00:00 2001 From: Shane Ferrell Date: Fri, 4 Aug 2023 07:32:23 -0700 Subject: [PATCH 5/6] know -> known --- Calendar/Get-RBASummary.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Calendar/Get-RBASummary.ps1 b/Calendar/Get-RBASummary.ps1 index a8d7b34575..02484367d6 100644 --- a/Calendar/Get-RBASummary.ps1 +++ b/Calendar/Get-RBASummary.ps1 @@ -310,7 +310,7 @@ function RBADelegateSettings { Write-Host "`t ForwardRequestsToDelegates: "$RbaSettings.ForwardRequestsToDelegates Write-Host - # Check for know configuration issues to warn about: + # Check for known configuration issues to warn about: if ($RbaSettings.ResourceDelegates.Count -gt 0) { if ($RbaSettings.AddNewRequestsTentatively -eq $true) { Write-Host "In-policy meetings will be marked tentative and the meeting request will be sent to the Resource Delegates to be accepted or rejected. Default" From 471081fd0a919737df6a253aa61c69c8965dfc1b Mon Sep 17 00:00:00 2001 From: Lukas Sassl Date: Fri, 4 Aug 2023 16:36:41 +0200 Subject: [PATCH 6/6] Quotes replaced --- Diagnostics/HealthChecker/Features/Get-HealthCheckerData.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Diagnostics/HealthChecker/Features/Get-HealthCheckerData.ps1 b/Diagnostics/HealthChecker/Features/Get-HealthCheckerData.ps1 index 864e919962..cd88896cd6 100644 --- a/Diagnostics/HealthChecker/Features/Get-HealthCheckerData.ps1 +++ b/Diagnostics/HealthChecker/Features/Get-HealthCheckerData.ps1 @@ -34,8 +34,8 @@ function Get-HealthCheckerData { } Invoke-Command -ComputerName $ComputerName -ScriptBlock { Get-Date } -ErrorAction Stop | Out-Null - $reg = [Microsoft.Win32.RegistryKey]::OpenRemoteBaseKey(“LocalMachine”, $ComputerName) - $reg.OpenSubKey(“SOFTWARE\Microsoft\Windows NT\CurrentVersion”) | Out-Null + $reg = [Microsoft.Win32.RegistryKey]::OpenRemoteBaseKey("LocalMachine", $ComputerName) + $reg.OpenSubKey("SOFTWARE\Microsoft\Windows NT\CurrentVersion") | Out-Null Write-Verbose "Returning true back" return $true } catch {