Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Some questions about deepspeed sequence parallel #6708

Open
yingtongxiong opened this issue Nov 4, 2024 · 4 comments
Open

[REQUEST] Some questions about deepspeed sequence parallel #6708

yingtongxiong opened this issue Nov 4, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@yingtongxiong
Copy link

Hello, I want to run sequence parallel on pure deepspeed repo. However, I found that it is necessary to let developer to create sequence parallel process group, is it right? I want to know there is any solutions to use sequence parallel or MoE(which also requires expert_data_process_group and so on) on pure deepspeed.

@yingtongxiong yingtongxiong added the enhancement New feature or request label Nov 4, 2024
@samadejacobs
Copy link
Contributor

@yingtongxiong , the recommended use of Deepspeed sequence parallelism (deepspeed ulysses) is to call it from a client framework/script. Please take a look at these two examples: Megatron-DeepSpeed, HugingFace transformer

@yingtongxiong
Copy link
Author

Okay Thank you very much

@yingtongxiong
Copy link
Author

https://github.com/microsoft/DeepSpeedExamples/blob/uly-hf/post_training/sequence_parallelism/test_ulysses.py#L113 I see in here, the mesh_param is commented, so I think if I want to use sp, this parameters should be transmitted, is it right? @samadejacobs

@yingtongxiong
Copy link
Author

Aslo, when I use sp all2all overlap, I found a little bug.

assert ctx.stream != None
when stream is not None, the assert is still False, so I think it should be "ctx.stream is not None".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants