-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Inference Benchmarking Scripts - Support AML #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohtana
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an example that shows how to run them?
@tohtana, thank you for the comment, I will update the README w/ examples showing how to run the scripts. |
mrwyattii
reviewed
Mar 5, 2024
awan-10
approved these changes
Mar 5, 2024
mrwyattii
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes/updates the inference benchmarking analysis scripts to support
[fastgen, vllm, aml]
backends. The scripts are generalized to support models beyond just Llama, which was hardcoded in the scripts previously. A number of bugs and formatting issues are also resolved. The scripts that were fixed/updated are:plot_effective_throughput.py
plot_latency_percentile.py
:plot_repl_scale.py
:plot_th_lat.py
:plot_tp_sizes.py
:Example plots for the scripts:
plot_effective_throughput.py
:plot_latency_percentile.py
:plot_repl_scale.py
:plot_th_lat.py
:NOTE: the resulting data should not be used to draw any conclusions. The GPUs, tp_size, etc are different across the different data points. This is simply demonstrating the plot generation.
plot_tp_sizes.py
: