Reduce memory fragmentation in x86 #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method used to allocate trampolines in Detours does not avoid memory fragmentation, which is especially important on platforms where the virtual address space is scarce (like x86).
In this patch we try to minimize the effects of fragmentation by modifying the requested allocation address so that it will be adjacent to the next occupied memory block.
Without this patch, there is a slight chance that in the course of allocating a new trampoline, Detours will undeliberately split a large contiguous memory block into two smaller blocks, thus causing fragmentation.
The effects of fragmentation can be disastrous, since some applications tend to allocate large quantities of memory as part of their start-up code. In case a single block large enough to fulfill the allocation request cannot be found, these applications
will simply fail to start.
Microsoft Reviewers: Open in CodeFlow