Skip to content

Commit b172fd8

Browse files
authored
Update CoPilot instructions and update ADO pipelines (#261)
1 parent 4e8a062 commit b172fd8

File tree

3 files changed

+28
-3
lines changed

3 files changed

+28
-3
lines changed

.azuredevops/pipelines/DirectXMath-GitHub-CMake-Dev17.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ variables:
4242
Codeql.Enabled: false
4343
VS_GENERATOR: 'Visual Studio 17 2022'
4444
WIN10_SDK: '10.0.19041.0'
45-
WIN11_SDK: '10.0.22000.0'
45+
WIN11_SDK: '10.0.26100.0'
4646

4747
pool:
4848
vmImage: windows-2022

.github/copilot-instructions.md

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,14 @@ Tests/ # Tests are designed to be cloned from a separate repository at th
4848
4949
## References
5050

51+
- [Source git repository on GitHub](https://github.com/microsoft/DirectXMath.git)
52+
- [DirectXMath wiki git repository on GitHub](https://github.com/microsoft/DirectXMath.wiki.git)
53+
- [DirectXMath test suite git repository on GitHub](https://github.com/walbourn/directxmathtest.wiki.git).
5154
- [C++ Core Guidelines](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)
5255
- [Microsoft Secure Coding Guidelines](https://learn.microsoft.com/en-us/security/develop/secure-coding-guidelines)
5356
- [CMake Documentation](https://cmake.org/documentation/)
54-
- [VCPK Documentation](https://learn.microsoft.com/vcpkg/)
57+
- [VCPKG Documentation](https://learn.microsoft.com/vcpkg/)
5558
- [DirectXMath Documentation](https://learn.microsoft.com/windows/win32/dxmath/directxmath-portal)
56-
- [DirectXMath Wiki](https://github.com/microsoft/DirectXMath/wiki/)
5759
- [Games for Windows and the DirectX SDK blog - March 2012](https://walbourn.github.io/introducing-directxmath/)
5860

5961
## No speculation
@@ -83,3 +85,25 @@ When creating documentation:
8385
- Review each documented item against source code whenever related to the task.
8486
- Remove any speculative content.
8587
- Ensure all documentation is verifiable against the current state of the codebase.
88+
89+
## Cross-platform Support Notes
90+
91+
- The code supports building for Windows and Linux.
92+
- Portability and conformance of the code is validated by building with Visual C++, clang/LLVM for Windows, MinGW, and GCC for Linux.
93+
94+
## Code Review Instructions
95+
96+
When reviewing code, focus on the following aspects:
97+
98+
- Adherence to coding standards defined in `.editorconfig` and on the [wiki](https://github.com/microsoft/DirectXTK/wiki/Implementation).
99+
- Make coding recommendations based on the *C++ Core Guidelines*.
100+
- Proper use of RAII and smart pointers.
101+
- Correct error handling practices and C++ Exception safety.
102+
- Clarity and maintainability of the code.
103+
- Adequate comments where necessary.
104+
- Public interfaces located in `Inc\*.h` should be clearly defined and documented on the Microsoft Docs pages.
105+
- Optional functions are available in headers in the `SHMath`, `Stereo3D`, `MatrixStack`, and `XDSP` folders.
106+
- Compliance with the project's architecture and design patterns.
107+
- Ensure that all public functions and classes are covered by unit tests located on [GitHub](https://github.com/walbourn/directxmathtest.git) where applicable. Report any gaps in test coverage.
108+
- Check for performance implications, especially in geometry processing algorithms.
109+
- Provide brutally honest feedback on code quality, design, and potential improvements as needed.

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
*.VC.db
1919
*.nupkg
2020
.vs
21+
.vscode
2122
/Tests
2223
/wiki
2324
/out

0 commit comments

Comments
 (0)