You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
-[Games for Windows and the DirectX SDK blog - March 2012](https://walbourn.github.io/introducing-directxmath/)
58
60
59
61
## No speculation
@@ -83,3 +85,25 @@ When creating documentation:
83
85
- Review each documented item against source code whenever related to the task.
84
86
- Remove any speculative content.
85
87
- Ensure all documentation is verifiable against the current state of the codebase.
88
+
89
+
## Cross-platform Support Notes
90
+
91
+
- The code supports building for Windows and Linux.
92
+
- Portability and conformance of the code is validated by building with Visual C++, clang/LLVM for Windows, MinGW, and GCC for Linux.
93
+
94
+
## Code Review Instructions
95
+
96
+
When reviewing code, focus on the following aspects:
97
+
98
+
- Adherence to coding standards defined in `.editorconfig` and on the [wiki](https://github.com/microsoft/DirectXTK/wiki/Implementation).
99
+
- Make coding recommendations based on the *C++ Core Guidelines*.
100
+
- Proper use of RAII and smart pointers.
101
+
- Correct error handling practices and C++ Exception safety.
102
+
- Clarity and maintainability of the code.
103
+
- Adequate comments where necessary.
104
+
- Public interfaces located in `Inc\*.h` should be clearly defined and documented on the Microsoft Docs pages.
105
+
- Optional functions are available in headers in the `SHMath`, `Stereo3D`, `MatrixStack`, and `XDSP` folders.
106
+
- Compliance with the project's architecture and design patterns.
107
+
- Ensure that all public functions and classes are covered by unit tests located on [GitHub](https://github.com/walbourn/directxmathtest.git) where applicable. Report any gaps in test coverage.
108
+
- Check for performance implications, especially in geometry processing algorithms.
109
+
- Provide brutally honest feedback on code quality, design, and potential improvements as needed.
0 commit comments