Skip to content

Security and Compliance | Added new resource device tenant policy.#5256

Closed
sasistla wants to merge 9 commits intoMicrosoft365DSC:Devfrom
sasistla:user/sasistla/SCDeviceTenantRule
Closed

Security and Compliance | Added new resource device tenant policy.#5256
sasistla wants to merge 9 commits intoMicrosoft365DSC:Devfrom
sasistla:user/sasistla/SCDeviceTenantRule

Conversation

@sasistla
Copy link
Copy Markdown
Contributor

Added new resource device tenant policy in S&C

@NikCharlebois
Copy link
Copy Markdown
Collaborator

Looks like you are missing the stub for the Remove-DeviceTenantPolicy cmdlet.

@FabienTschanz
Copy link
Copy Markdown
Collaborator

@NikCharlebois Do you want to review this PR? Currently checking the PRs and issues.

Copy link
Copy Markdown
Collaborator

@NikCharlebois NikCharlebois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment to address.

(
[Parameter()]
[System.String]
$Guid,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the key, it is required for the property to be marked as mandatory. Otherwise Start-DSCConfiguration will fail.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sasistla, could you please fix this last comment today? Then we can include it in the next release.

@NikCharlebois
Copy link
Copy Markdown
Collaborator

Putting this PR On-Hold as we are awaiting additional details from the owning PG to better understand how the underlying cmdlets work and what their impact on the environment is.

@FabienTschanz
Copy link
Copy Markdown
Collaborator

@NikCharlebois Did you receive feedback from the PG?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants