Skip to content

Commit 34d1a25

Browse files
committed
Deprecate to_xarray_dataarray_dict
1 parent f119f6a commit 34d1a25

File tree

4 files changed

+29
-6
lines changed

4 files changed

+29
-6
lines changed

src/qcodes/dataset/data_set.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import numpy
1616
import numpy.typing as npt
1717
from tqdm.auto import trange
18+
from typing_extensions import deprecated
1819

1920
import qcodes
2021
from qcodes.dataset.data_set_protocol import (
@@ -84,6 +85,7 @@
8485
from qcodes.utils import (
8586
NumpyJSONEncoder,
8687
)
88+
from qcodes.utils.deprecate import QCoDeSDeprecationWarning
8789

8890
from .data_set_cache import DataSetCacheWithDBBackend
8991
from .data_set_in_memory import DataSetInMem, load_from_file
@@ -95,7 +97,7 @@
9597
load_to_dataframe_dict,
9698
)
9799
from .exporters.export_to_xarray import (
98-
load_to_xarray_dataarray_dict,
100+
load_to_xarray_dataarray_dict, # pyright: ignore[reportDeprecated]
99101
load_to_xarray_dataset,
100102
load_to_xarray_dataset_dict,
101103
xarray_to_h5netcdf_with_complex_numbers,
@@ -965,6 +967,10 @@ def to_pandas_dataframe(
965967
datadict = self.get_parameter_data(*params, start=start, end=end)
966968
return load_to_concatenated_dataframe(datadict, self.description.interdeps)
967969

970+
@deprecated(
971+
"to_xarray_dataarray_dict is deprecated, use to_xarray_dataset_dict instead",
972+
category=QCoDeSDeprecationWarning,
973+
)
968974
def to_xarray_dataarray_dict(
969975
self,
970976
*params: str | ParamSpec | ParameterBase,
@@ -1026,7 +1032,7 @@ def to_xarray_dataarray_dict(
10261032
10271033
"""
10281034
data = self.get_parameter_data(*params, start=start, end=end)
1029-
datadict = load_to_xarray_dataarray_dict(
1035+
datadict = load_to_xarray_dataarray_dict( # pyright: ignore[reportDeprecated]
10301036
self, data, use_multi_index=use_multi_index
10311037
)
10321038

src/qcodes/dataset/data_set_cache.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,18 @@
66

77
import numpy as np
88
import numpy.typing as npt
9+
from typing_extensions import deprecated
910

1011
from qcodes.dataset.exporters.export_info import ExportInfo
1112
from qcodes.dataset.sqlite.queries import completed, load_new_data_for_rundescriber
13+
from qcodes.utils import QCoDeSDeprecationWarning
1214

1315
from .exporters.export_to_pandas import (
1416
load_to_concatenated_dataframe,
1517
load_to_dataframe_dict,
1618
)
1719
from .exporters.export_to_xarray import (
18-
load_to_xarray_dataarray_dict,
20+
load_to_xarray_dataarray_dict, # pyright: ignore[reportDeprecated]
1921
load_to_xarray_dataset,
2022
load_to_xarray_dataset_dict,
2123
)
@@ -186,6 +188,10 @@ def to_pandas_dataframe(self) -> pd.DataFrame:
186188
data = self.data()
187189
return load_to_concatenated_dataframe(data, self.rundescriber.interdeps)
188190

191+
@deprecated(
192+
"to_xarray_dataarray_dict is deprecated, use to_xarray_dataset_dict instead",
193+
category=QCoDeSDeprecationWarning,
194+
)
189195
def to_xarray_dataarray_dict(
190196
self, *, use_multi_index: Literal["auto", "always", "never"] = "auto"
191197
) -> dict[str, xr.DataArray]:
@@ -201,7 +207,7 @@ def to_xarray_dataarray_dict(
201207
202208
"""
203209
data = self.data()
204-
data_dict = load_to_xarray_dataarray_dict(
210+
data_dict = load_to_xarray_dataarray_dict( # pyright: ignore[reportDeprecated]
205211
self._dataset, data, use_multi_index=use_multi_index
206212
)
207213
return data_dict

src/qcodes/dataset/data_set_in_memory.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
import numpy as np
1313
import numpy.typing as npt
14+
from typing_extensions import deprecated
1415

1516
from qcodes.dataset.data_set_protocol import (
1617
SPECS,
@@ -40,7 +41,7 @@
4041
update_parent_datasets,
4142
update_run_description,
4243
)
43-
from qcodes.utils import NumpyJSONEncoder
44+
from qcodes.utils import NumpyJSONEncoder, QCoDeSDeprecationWarning
4445

4546
from .data_set_cache import DataSetCacheDeferred, DataSetCacheInMem
4647
from .dataset_helpers import _add_run_to_runs_table
@@ -848,6 +849,10 @@ def _parameters(self) -> str | None:
848849
else:
849850
return None
850851

852+
@deprecated(
853+
"to_xarray_dataarray_dict is deprecated, use to_xarray_dataset_dict instead",
854+
category=QCoDeSDeprecationWarning,
855+
)
851856
def to_xarray_dataarray_dict(
852857
self,
853858
*params: str | ParamSpec | ParameterBase,
@@ -856,7 +861,7 @@ def to_xarray_dataarray_dict(
856861
use_multi_index: Literal["auto", "always", "never"] = "auto",
857862
) -> dict[str, xr.DataArray]:
858863
self._warn_if_set(*params, start=start, end=end)
859-
return self.cache.to_xarray_dataarray_dict()
864+
return self.cache.to_xarray_dataarray_dict() # pyright: ignore[reportDeprecated]
860865

861866
def to_xarray_dataset_dict(
862867
self,

src/qcodes/dataset/exporters/export_to_xarray.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,10 @@
77
from typing import TYPE_CHECKING, Literal
88

99
from packaging import version as p_version
10+
from typing_extensions import deprecated
1011

1112
from qcodes.dataset.linked_datasets.links import links_to_str
13+
from qcodes.utils import QCoDeSDeprecationWarning
1214

1315
from ..descriptions.versioning import serialization as serial
1416
from .export_to_pandas import (
@@ -210,6 +212,10 @@ def _xarray_data_array_direct(
210212
return ds
211213

212214

215+
@deprecated(
216+
"load_to_xarray_dataarray_dict is deprecated, use load_to_xarray_dataarray_dict instead",
217+
category=QCoDeSDeprecationWarning,
218+
)
213219
def load_to_xarray_dataarray_dict(
214220
dataset: DataSetProtocol,
215221
datadict: Mapping[str, Mapping[str, npt.NDArray]],

0 commit comments

Comments
 (0)