Skip to content

Commit 4359419

Browse files
author
Thomas Lemon
committed
Update get_s to use expected measurement_duration as timeout.
1 parent 25ee188 commit 4359419

File tree

1 file changed

+16
-12
lines changed
  • src/qcodes/instrument_drivers/CopperMountain

1 file changed

+16
-12
lines changed

src/qcodes/instrument_drivers/CopperMountain/_M5xxx.py

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ def _set_trigger(self, trigger: str) -> None:
494494
self.write("TRIG:SOUR " + trigger.upper())
495495

496496
def get_s(
497-
self,
497+
self, expected_measurement_duration: float = 600
498498
) -> tuple[
499499
np.ndarray,
500500
np.ndarray,
@@ -509,6 +509,9 @@ def get_s(
509509
"""
510510
Return all S parameters as magnitude in dB and phase in rad.
511511
512+
Args:
513+
expected_measurement_duration: Expected duration of the measurement in seconds.
514+
512515
Returns:
513516
Tuple[np.ndarray]: frequency [GHz],
514517
s11 magnitude [dB], s11 phase [rad],
@@ -518,17 +521,18 @@ def get_s(
518521
519522
"""
520523

521-
self.write("CALC1:PAR:COUN 4") # 4 trace
522-
self.write("CALC1:PAR1:DEF S11") # Choose S11 for trace 1
523-
self.write("CALC1:PAR2:DEF S12") # Choose S12 for trace 2
524-
self.write("CALC1:PAR3:DEF S21") # Choose S21 for trace 3
525-
self.write("CALC1:PAR4:DEF S22") # Choose S22 for trace 4
526-
self.write("CALC1:TRAC1:FORM SMITH") # Trace format
527-
self.write("CALC1:TRAC2:FORM SMITH") # Trace format
528-
self.write("CALC1:TRAC3:FORM SMITH") # Trace format
529-
self.write("CALC1:TRAC4:FORM SMITH") # Trace format
530-
self.write("TRIG:SEQ:SING") # Trigger a single sweep
531-
self.ask("*OPC?") # Wait for measurement to complete
524+
with self.timeout.set(max(self.timeout(), expected_measurement_duration)):
525+
self.write("CALC1:PAR:COUN 4") # 4 trace
526+
self.write("CALC1:PAR1:DEF S11") # Choose S11 for trace 1
527+
self.write("CALC1:PAR2:DEF S12") # Choose S12 for trace 2
528+
self.write("CALC1:PAR3:DEF S21") # Choose S21 for trace 3
529+
self.write("CALC1:PAR4:DEF S22") # Choose S22 for trace 4
530+
self.write("CALC1:TRAC1:FORM SMITH") # Trace format
531+
self.write("CALC1:TRAC2:FORM SMITH") # Trace format
532+
self.write("CALC1:TRAC3:FORM SMITH") # Trace format
533+
self.write("CALC1:TRAC4:FORM SMITH") # Trace format
534+
self.write("TRIG:SEQ:SING") # Trigger a single sweep
535+
self.ask("*OPC?") # Wait for measurement to complete
532536

533537
# Get data as string
534538
freq_raw = self.ask("SENS1:FREQ:DATA?")

0 commit comments

Comments
 (0)