Skip to content

Commit 8fb3820

Browse files
committed
Fix type checking consistency
1 parent c8e5a7c commit 8fb3820

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

src/qcodes/dataset/data_set_cache.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,10 @@ def to_xarray_dataarray_dict(
200200
201201
"""
202202
data = self.data()
203-
return load_to_xarray_dataarray_dict(
203+
data_dict = load_to_xarray_dataarray_dict(
204204
self._dataset, data, use_multi_index=use_multi_index
205205
)
206+
return {key: val[key] for key, val in data_dict.items()}
206207

207208
def to_xarray_dataset(
208209
self, *, use_multi_index: Literal["auto", "always", "never"] = "auto"

src/qcodes/dataset/exporters/export_to_xarray.py

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def _calculate_index_shape(idx: pd.Index | pd.MultiIndex) -> dict[Hashable, int]
6161
return expanded_shape
6262

6363

64-
def _load_to_xarray_dataarray_dict_no_metadata(
64+
def _load_to_xarray_dataset_dict_no_metadata(
6565
dataset: DataSetProtocol,
6666
datadict: Mapping[str, Mapping[str, npt.NDArray]],
6767
*,
@@ -220,18 +220,21 @@ def load_to_xarray_dataarray_dict(
220220
datadict: Mapping[str, Mapping[str, npt.NDArray]],
221221
*,
222222
use_multi_index: Literal["auto", "always", "never"] = "auto",
223-
) -> dict[str, xr.Dataset]:
224-
dataarrays = _load_to_xarray_dataarray_dict_no_metadata(
223+
) -> dict[str, xr.DataArray]:
224+
xr_datasets = _load_to_xarray_dataset_dict_no_metadata(
225225
dataset, datadict, use_multi_index=use_multi_index
226226
)
227+
data_arrays: dict[str, xr.DataArray] = {}
227228

228-
for dataname, dataarray in dataarrays.items():
229-
_add_param_spec_to_xarray_coords(dataset, dataarray)
229+
for dataname, xr_dataset in xr_datasets.items():
230+
data_array = xr_dataset[dataname]
231+
_add_param_spec_to_xarray_coords(dataset, data_array)
230232
paramspec_dict = _paramspec_dict_with_extras(dataset, str(dataname))
231-
dataarray.attrs.update(paramspec_dict.items())
232-
_add_metadata_to_xarray(dataset, dataarray)
233+
data_array.attrs.update(paramspec_dict.items())
234+
_add_metadata_to_xarray(dataset, data_array)
235+
data_arrays[dataname] = data_array
233236

234-
return dataarrays
237+
return data_arrays
235238

236239

237240
def _add_metadata_to_xarray(
@@ -270,7 +273,7 @@ def load_to_xarray_dataset(
270273
) -> xr.Dataset:
271274
import xarray as xr
272275

273-
data_xrdarray_dict = _load_to_xarray_dataarray_dict_no_metadata(
276+
data_xrdarray_dict = _load_to_xarray_dataset_dict_no_metadata(
274277
dataset, data, use_multi_index=use_multi_index
275278
)
276279

0 commit comments

Comments
 (0)