Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle missing Service Principal permissions #335

Open
3 tasks
colbylwilliams opened this issue May 9, 2022 · 0 comments
Open
3 tasks

Better handle missing Service Principal permissions #335

colbylwilliams opened this issue May 9, 2022 · 0 comments
Assignees
Labels
dev Development tasks (contributors only) documentation Improvements or additions to documentation

Comments

@colbylwilliams
Copy link
Member

Related to issues #332 and #334 we need be better handle when the service principal doesn't have the appropriate permissions on a management group and subscriptions when populating the form data for resource manager deployment scope creation.

We should:

  • Gracefully fail if the Service Principal does have the permissions to get a Management Group name/id, but doesn't have the permissions to list the subscriptions on the group. Currently we just error out, but we should expose the error to the user with steps they can take to fix this (i.e. grant the SP permission to list the subscriptions on a management group)
  • Add description on the web UI to explain that only subscriptions that the Service Principal has access to will be available to select. Possibly show the SP's id or name in this description to further simplify steps to grant permission.
  • Update (and add missing) documentation around all of this
@colbylwilliams colbylwilliams added the dev Development tasks (contributors only) label May 9, 2022
@colbylwilliams colbylwilliams added the documentation Improvements or additions to documentation label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Development tasks (contributors only) documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants