-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript 4.4 libdom changes #1029
Comments
High Level Changes from 4.3 to 4.4
|
The following four types also seems to be removed, but are not mentioned in the above list :
|
|
Found undocumented breaking change: navigator.permissions.query({ name: 'camera' }) See: https://w3c.github.io/permissions/#enumdef-permissionname |
Breaking change documented wrong:
// 4.3
interface CryptoKeyPair {
privateKey: CryptoKey;
publicKey: CryptoKey;
}
// 4.4
interface CryptoKeyPair {
privateKey?: CryptoKey;
publicKey?: CryptoKey;
} |
In 4.3 it is |
Camera permission is at risk because of lack of multiple implementation, so I guess the work item is to document the removal.
|
I want to add (deprecated: ref #884) |
Undocumented change |
I tried upgrading from TS 4.3.5 to 4.4.2 today and encountered two issues:
It would be great if these changes could be reverted. |
Chrome/Edge/Opera all uses the same engine Blink and no other engine supports it without a flag, that is why. Please refer to https://github.com/microsoft/TypeScript-DOM-lib-generator#when-the-type-is-missing for the reasoning here.
Fixed by #1111 |
Thanks, I read that section of the README but it's not clear about flagged features, plus |
Why was |
Fixed by #1104 |
|
It's currently a Firefox specific extension, so yes, that was intended. |
Hello, is there a remplacement api ? |
It's not deprecated, it's just not mature enough with no prefix-less implementation and being still in WICG (where immature specifications exist). |
Just a query, maybe my bad understanding, but File.webkitRelativePath is not a standard property and, according to MDN, should NOT be used on production sites. Can this be made optional or removed (or is my understanding here wrong)? https://developer.mozilla.org/en-US/docs/Web/API/File/webkitRelativePath |
@saschanaz, thank you! If you or anyone else knows when TypeScript itself will be updated with this change, that would be helpful. |
Likely in TypeScript 4.8, so roughly 3 months from now |
@orta, I see. Thank you. |
They MUST NOT be removed. They are actually defined in the specification. |
Please check README. (And MDN browser compatibility) |
I see. You should edit the following too: TypeScript-DOM-lib-generator/baselines/dom.generated.d.ts Lines 1726 to 1742 in 6683182
|
Includes changes to `font-face.d.ts` because TypeScript added support for `FontFace` in v4.4, though it is not 100% complete. microsoft/TypeScript-DOM-lib-generator#1029 (comment)
@orta I find a Type bug of Font Face API: microsoft/TypeScript#51885 |
+ to use the latest lib.dom.d.ts + see: microsoft/TypeScript-DOM-lib-generator#1029
I dont this this issue still needs to stay open... |
Yeah, time to close this. @github-actions close |
Eh. Error: Resource not accessible by integration. @jakebailey, can you check? Thanks! |
Fixed in #1799; didn't realize the codeowners system could also close issues. |
Thank you! @github-actions close |
Closing because @saschanaz is one of the code-owners of this repository. |
Beta
With TypeScript 4.4, we coordinated some pretty fundamental infrastructure work to prepare for the version of
dom.d.ts
with the future of the generator repo. This work resulted in two note-worthy items:The
dom.d.ts
files typically accessed inside TypeScript are now also deployed to@types/web
starting with version0.0.1
which corresponds to the version oflibdom.d.ts
in TypeScript 4.3. This means an update to TypeScript 4.4 does not mean you have to update all of your web.d.ts
files.The name change is to more accurately reflect the scope of the APIs, for a long time the file has provided much more APIs than just the DOM and
@types/web
reflects that. If you're interested in switching to use@types/web
, there are instructions in the npm README.The 4.4
dom.d.ts
file which is included with TypeScript includes quite a lot of changes, with a lot of APIs which have been marked as deleted by the web standards committees. You can see the full list in this issueWe've been testing these changes with DefinitelyTyped, and have been individually rolling back changes which we think are a bit too breaking, this is more of an art than a science however. If you think we should rollback a particular change we're open to discussing change in this issue or the
dom-lib-generator
channel in the TypeScript Community DiscordWe plan to have thorough support for replacing
lib.dom.d.ts
with@types/web
in 4.5 with microsoft/TypeScript#44795The text was updated successfully, but these errors were encountered: