Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disposition field to SecurityPolicyViolationEvent interface #1030

Closed
bsafwen opened this issue Jun 26, 2021 · 4 comments
Closed

Add disposition field to SecurityPolicyViolationEvent interface #1030

bsafwen opened this issue Jun 26, 2021 · 4 comments

Comments

@bsafwen
Copy link

bsafwen commented Jun 26, 2021

lib Update Request

Configuration Check

My compilation target is ES2015 and my lib is ["esnext", "dom"].

Missing / Incorrect Definition

the interface SecurityPolicyViolationEvent is missing the disposition field.

Sample Code

private checkSecPolicyViolation(event: SecurityPolicyViolationEvent) {
    if (event.disposition === 'report') return "not important";
    else if (event.disposition === 'enforce') return "something needs to be done";
}

Documentation Link

According to https://www.w3.org/TR/CSP3/#violation-events, the interface SecurityPolicyViolationEvent has a field called disposition. This field is present in Chrome, Firefox, Safari.

@andrewbranch andrewbranch transferred this issue from microsoft/TypeScript Jun 28, 2021
@andrewbranch
Copy link
Member

Transferred to TypeScript-DOM-lib-generator. Feel free to check the README and open a PR. Thanks!

NotWoods added a commit to NotWoods/TypeScript-DOM-lib-generator that referenced this issue Jul 2, 2021
@tosmolka
Copy link
Member

Was this issue fixed by saschanaz@86b265a or we still need #1037 ?

@saschanaz
Copy link
Contributor

Yeah, #1034 did it.

@github-actions close

@github-actions
Copy link
Contributor

Closing because @saschanaz is one of the code-owners of this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants