Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.parentElement should be Element, not HTMLElement #1706

Open
jonahShaf opened this issue Apr 17, 2024 · 1 comment
Open

Node.parentElement should be Element, not HTMLElement #1706

jonahShaf opened this issue Apr 17, 2024 · 1 comment

Comments

@jonahShaf
Copy link

In lib.dom.d.ts Node.parentElement is defined as being HTMLelement | null. However, it should Element | null. The spec confirms this. This issue was originally fixed by #885 but was reverted in c81fa76. I didn't see any reasoning attached to that revert commit and the typing is still incorrect after the revert.
@HolgerJeromin
Copy link
Contributor

This whole topic is not about implementing the spec but about usability.
#1151 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HolgerJeromin @jonahShaf