Skip to content

API Descriptions Update #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 97 commits into from
Apr 17, 2025
Merged

API Descriptions Update #1940

merged 97 commits into from
Apr 17, 2025

Conversation

Bashamega
Copy link
Contributor

fixes #1937

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@saschanaz
Copy link
Contributor

We still depend on that, so we can't just remove it until we get a new mdn/content dependency?

@Bashamega
Copy link
Contributor Author

We still depend on that, so we can't just remove it until we get a new mdn/content dependency?

I know

@Bashamega Bashamega marked this pull request as ready for review March 15, 2025 15:57
@Bashamega
Copy link
Contributor Author

Hello @saschanaz,
I have created a script to generate the JSON, ran the baseline command, and fixed some linting problems, but I don't know how to solve the error you see in the logs. It is just one error.

@saschanaz
Copy link
Contributor

Maybe npm i?

@Bashamega
Copy link
Contributor Author

Maybe npm i?

Hello:)
How will npm i help?
I ran it and it didn't do anything

@saschanaz
Copy link
Contributor

saschanaz commented Mar 16, 2025

I mean npm i && npm run build && npm run baseline-accept? Because it seems like it's caused by mismatch of installed dependency version. npm i fixes that.

@Bashamega
Copy link
Contributor Author

I mean npm i && npm run build && npm run baseline-accept? Because it seems like it's caused by mismatch of dependency version. npm i fixes that.
oh okay

@Bashamega Bashamega requested a review from saschanaz March 16, 2025 09:50
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically seems good to me; @saschanaz seem alright as a first go?

@Bashamega Bashamega requested a review from saschanaz April 16, 2025 04:07
@Bashamega
Copy link
Contributor Author

Hi @saschanaz, @jakebailey, @sandersn 👋

I've looked into ways to clone only specific parts of a repo without fetching the entire repository. Git doesn't support this natively, but I found a practical workaround using SVN (Subversion).

Although it's an older tool, it’s still supported by GitHub and allows downloading a single directory without pulling the whole repo. This might be a viable solution for our case—just wanted to share as a proposal for consideration.

@jakebailey
Copy link
Member

I don't think we need to do anything fancy. The submodule is fine.

@Bashamega
Copy link
Contributor Author

I don't think we need to do anything fancy. The submodule is fine.

Okay, do you have any estimation of when this pr will be merged?

@saschanaz
Copy link
Contributor

SVN is not supported by GitHub https://github.blog/news-insights/product-news/sunsetting-subversion-support/ (I'm pretty surprised that it was supported at all)

@saschanaz
Copy link
Contributor

I see no blocker to not merge.

@Bashamega
Copy link
Contributor Author

Bashamega commented Apr 17, 2025

SVN is not supported by GitHub https://github.blog/news-insights/product-news/sunsetting-subversion-support/ (I'm pretty surprised that it was supported at all)

Good to know, I didn't know

I see no blocker to not merge.

Me too. Can you merge it?

@saschanaz
Copy link
Contributor

I mean only if I could... 🤷🏻‍♀️

LGTM

Copy link
Contributor

@Bashamega
Copy link
Contributor Author

Hello @jakebailey
Sorry for pinging you, but I think this PR is ready to be merged

@jakebailey
Copy link
Member

I'll merge it now, I had just replied late at night 😄

@jakebailey jakebailey merged commit 7b677e2 into microsoft:main Apr 17, 2025
7 checks passed
@Bashamega
Copy link
Contributor Author

I'll merge it now, I had just replied late at night 😄

Thank you very much for merging this huge PR. You just made my day :)

@Bashamega Bashamega mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Automate API Descriptions Update via GitHub Action
4 participants