Merge types_web back into TypeScript DOM lib generator #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2021
* Update README to match the new code This should match better with the code after #1034. * feedback * link to contribution guidelines * Update README.md Co-authored-by: Nathan Shively-Sanders <[email protected]> * Update README.md Co-authored-by: Nathan Shively-Sanders <[email protected]>
Closed
This was referenced Aug 25, 2021
Closed
Closed
This was referenced Sep 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in all the changes, and merges the changes to the TS repo at the same time. The output .d.ts files post-merge basically match the version in the compiler with the exceptions of the PRs I submitted to types_web which I haven't got into a mergeable state yet.
Me and @sandersn have gone through the types-web d.ts files with a pretty fine brush in prep for migrating to use that version for 4.4 ( #1023 ) so I'm pretty happy with the output.
The merge was pretty rough, so I tended to prefer the types-web version for source code, then try make sure both was applied to anything in the JSON.