-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge types_web back into TypeScript DOM lib generator #1034
Merged
Merged
Changes from all commits
Commits
Show all changes
365 commits
Select commit
Hold shift + click to select a range
fe5f1cd
feat(types): add input-events
saschanaz 461adc9
feat(types): add entries-api
saschanaz 357169a
feat(types): add mediacapture-fromelement
saschanaz 6fec72b
feat(types): add EXT_color_*/EXT_float_bleand
saschanaz 9291a3c
fix(types): restore WEBGL_color_buffer_float, still supported by brow…
saschanaz 624fb0a
feat(types): add wai-aria
saschanaz 55788a4
feat(types): add css-shadow-parts
saschanaz 3b2f317
feat(types): add storage-access
saschanaz d8bf7ce
chore(types): add image-capture (no new type)
saschanaz 95205b0
chore(types): add mediacapture-depth (no new type)
saschanaz 67318f4
chore(types): add web-otp (no new type)
saschanaz a4c9b59
chore(types): add event-timing (no new type)
saschanaz 0f69d55
chore(types): add webrtc-insertable-streams (no new type)
saschanaz 6ea491b
feat(types): add webrtc-priority
saschanaz 335bed1
feat(types): add webrtc-stats
saschanaz 7ca5ce7
chore(types): add webrtc-svc (no new type)
saschanaz 1a2a9b6
feat(types): add webxr-gamepads-module
saschanaz b0a63e3
chore(types): add css-counter-styles/css-device-adapt (no new type)
saschanaz b5463ad
feat(types): add css-animations-2/css-transitions-2
saschanaz ea6034a
feat: fetch spec list from browser-specs (#8)
saschanaz 89f0ceb
fix(types): prefer standard WebRTC dictionaries
saschanaz 749da81
fix(types): remove dependency on legacy Edge data
saschanaz 9072a3c
chore(removedTypes): cleanup
saschanaz f0be902
refactor(widlprocess): drop `extends: "Object"`
saschanaz d91e8ba
refactor(index): remove mixin redundancy check
saschanaz d848f85
chore(types): remove redundant flags
saschanaz 411ae2e
fix(types): remove nonstandard webcrypto types
saschanaz 4ad3437
fix(widlprocess): process partial namespaces separately
saschanaz 32e0a60
chore(knownTypes): remove redundant values
saschanaz 0506730
chore(package): update webref to ae50d8f
saschanaz 5e59677
chore(package): update @types/node
saschanaz 52946af
chore(package): mark dependencies as dev
saschanaz b75a0cd
docs: add "how to use" part
saschanaz db97ff8
docs: add more descriptions
saschanaz ef01309
docs: add an image example
saschanaz 8d5a633
docs: allow comments inside json
saschanaz 5f23c5c
docs: link to the npm page
saschanaz 73a5ec7
chore(package): add proper field values
saschanaz f9f2c6c
chore(deps-dev): bump typescript (#11)
dependabot[bot] 5d2b545
chore(package): bump version number to 0.1.1
saschanaz a4969b8
docs: fix webworker example
saschanaz 617051f
chore(types): remove ChildNode hack
saschanaz 7f3608f
test: add ChildNode unit test
saschanaz c762386
chore(unittests): make jsconfig cover unit test files
saschanaz c0290cb
chore(package): update browser-specs and webref
saschanaz 1f43a8d
fix(types): expose WEBGL_compressed_texture_etc to workers
saschanaz d5688b8
feat(types): add beforeinput event to GlobalEventHandlersEventMap
marijnh 20bcd49
chore(index): fix spec name
saschanaz 5fd7f1a
feat(types): add composition events to GlobalEventHandlers
marijnh e20c9d1
refactor(emitter): use Array#flatMap()
saschanaz 5b0c618
refactor(helper): rename to mapValues
saschanaz a7000c2
docs: describe when features can be unavailable
saschanaz d1e6d31
refactor: move build modules to src/build
saschanaz 8c7d035
feat(workflows): autoupdate webref
saschanaz a8551da
fix(workflows/update-webref): conditional run
saschanaz 6a13641
fix(workflows/update-webref): continue-on-error
saschanaz 474c2cb
fix(types): window.orientation is a number
saschanaz b2b1943
fix(types): remove obsolete entityReferenceExpansion support
saschanaz 94814b7
fix(types): remove Gecko-only force reload signature
saschanaz e3f46d9
fix(types): remove unsupported KeyboardEvent#char
saschanaz d1d1946
fix(types): remove Node#namespaceURI
saschanaz 335a660
fix(types): remove obsolete MouseWheelEvent
saschanaz 5c1219f
chore(types): reduce redundant override-type in webcrypto
saschanaz c214d51
feat(emitter): support additional-types
saschanaz 138255f
docs: replace the image with higher resolution
saschanaz d0e0e00
docs: try making the image more crisp on GitHub
saschanaz 2bffd44
feat(types): allow URL object for url string parameters
saschanaz 8a2a6b0
refactor: rename type-parameters to typeParameters
saschanaz c63fdcc
refactor: rename anonymous-methods to anonymousMethods
saschanaz 5f4f8a2
refactor: rename override-type to overrideType
saschanaz 766d6aa
refactor: rename additional-types to additionalTypes
saschanaz a2b90c8
refactor: rename override-signatures to overrideSignatures
saschanaz f3374e5
refactor: rename additional-signatures to additionalSignatures
saschanaz 0f39df1
refactor: rename attributeless-events to attributelessEvents
saschanaz 24bcae1
refactor: rename named-constructor as namedConstructor
saschanaz 268e637
refactor: rename override-exposed to overrideExposed
saschanaz 191ea44
refactor: rename no-interface-object to noInterfaceObject
saschanaz e5a189f
refactor: rename legacy-window-alias as legacyWindowAlias
saschanaz 63ef20d
refactor: rename legacy-namespace as legacyNamespace
saschanaz ab89e58
refactor: rename override-index-signatures to overrideIndexSignatures
saschanaz e234de1
refactor: rename callbacks to camel cases
saschanaz cf58be0
refactor: rename new-type as name
saschanaz 7406648
refactor: rename event-handler as eventHandler
saschanaz 95cf1c1
refactor: rename read-only as readonly
saschanaz 7c05e57
refactor: remove redundant callback: 1
saschanaz 8fca3db
refactor: remove redundant static interface support
saschanaz 74678d7
refactor: make .static as boolean
saschanaz 455f902
refactor: make .stringifier as boolean
saschanaz ea85b89
refactor: make .getter as boolean
saschanaz 4dc8248
refactor: replace property.required with .optional
saschanaz aba4766
refactor: make dictionarymember.required as boolean
saschanaz a738e8c
refactor: make .deprecated as boolean
saschanaz 1d101f5
refactor: convert nullable/optional/variadic to booleans
saschanaz 4878ace
refactor(build/emitter): simplify nullability check
saschanaz 2cd8ad3
feat(build/emitter): follow nullable flag for overrideType
saschanaz cbce2d9
refactor(build/emitter): simplify isCovariantEventHandler()
saschanaz ca98122
feat(types): add promise rejection events to workers
saschanaz e507c47
fix(types): revive wasm error interfaces
saschanaz 44bdec9
refactor(build/emitter): use nullish coalescing
saschanaz 95be3fe
chore(package): bump version number to 0.1.2
saschanaz f78b5b6
chore(package): add keywords
saschanaz 0afeec5
chore(unittests): use --types to disable types packages
saschanaz 216c71d
refactor: remove const enum Flavor
saschanaz 9c6f532
feat(types): add audioworklet library
saschanaz 4dc41d6
BREAKING CHANGE: add separate worker libraries, removes existing one
saschanaz b15b2a6
chore: keep webworker* as-is
saschanaz 106abcb
chore(package): bump version number to 0.1.3
saschanaz 903e960
docs: add more workers
saschanaz 39d238b
style: deploy typescript-eslint
saschanaz dc371cf
style: deploy prettier
saschanaz 467f05c
fix(workflows/update-webref): use expression for status
saschanaz 15d5474
fix(workflows/update-webref): use outcome
saschanaz e6a33a6
fix(workflows/update-webref): merge jobs
saschanaz def642d
fix(workflows/update-webref): check git diff
saschanaz b3881e2
chore(dependabot): weekly updates
saschanaz 76c487a
fix(types): restore highWaterMark
saschanaz 9e55e83
fix(types): mark wordWrap as deprecated
saschanaz 535341b
feat: add changelog builder
saschanaz 1fee742
chore(package): bump version number to v0.1.4
saschanaz e0562d6
fix(types): mark applicable var declarations as deprecated
saschanaz f8cb4e8
fix(types): mark webrtc callback-based methods as deprecated
saschanaz 184b0e6
chore(deprecatedMessage): remove redundant items
saschanaz b1a832d
fix(workflows/update-webref): add missing --quiet
saschanaz 0cabe70
fix(types): mark `prototype` property of constructors as `readonly`
ExE-Boss aa603a4
chore(package): bump version number to v0.1.5
saschanaz 6767562
chore(package): update deps
saschanaz 2ed98ce
chore(deps-dev): bump typescript from 4.2.0-dev.20201221 to 4.2.0-dev…
dependabot[bot] 4b66e21
chore(package): add more keywords
saschanaz 24bc5a4
fix(types): make ImportMeta.url required
orta 800e903
chore(types): no 1 anymore
saschanaz 43b2f82
feat(types): update bcd to 3.0.2
saschanaz 5b799f2
chore(package): bump version number to v0.1.6
saschanaz eafed28
chore(package): update deps
saschanaz 4f445e0
chore(package): update to bcd 3.0.3
saschanaz af530a6
chore(dependabot): update monthly
saschanaz a467892
chore(package): update deps
saschanaz 579372a
feat(types): remove .colorAdjust and add .crossOriginIsolated
saschanaz bfe9798
chore(package): bump version number to v0.1.7
saschanaz 5b7fd47
fix(build/widlprocess): trim line ends of comments
saschanaz 408e26f
fix(build/emitter): indent only for non-empty line
saschanaz fc483d7
fix(workflows/update-webref): prevent diff failure report
saschanaz cb816ba
chore(package): update webref (#53)
github-actions[bot] eaeee2f
chore(deps-dev): bump typescript (#54)
dependabot[bot] 9a94261
chore(package): update webref (#55)
github-actions[bot] 2b3ec68
chore(package): update to bcd 3.0.5
saschanaz 2a812f4
chore(package): update deps
saschanaz 90af280
chore(package): update webref (#62)
github-actions[bot] be8fff5
fix(build/emitter): remove length property check
saschanaz 3d29047
docs: restructure
saschanaz 26a4ddd
chore(package): update deps
saschanaz b485e9e
chore(package): update to bcd 3.1.1
saschanaz 076ca2b
chore(package): update webref (#64)
github-actions[bot] d9d4a14
chore(package): update to bcd 3.1.2
saschanaz 20183b7
chore(types): remove redundant overriding
saschanaz a225373
feat(types): Add `shared: boolean` for `MemoryDescriptor` dict
timhwang21 5888b03
chore(deps-dev): bump eslint from 7.19.0 to 7.21.0 (#67)
dependabot[bot] 9b89bc2
chore(deps-dev): bump eslint-config-prettier from 7.2.0 to 8.1.0 (#69)
dependabot[bot] 1eefcb6
chore(deps-dev): bump @typescript-eslint/parser from 4.15.0 to 4.15.2…
dependabot[bot] 7fcd30d
chore(deps-dev): bump @typescript-eslint/eslint-plugin (#70)
dependabot[bot] 2a8706d
chore(dependabot): set versioning strategy to increase
saschanaz 5798d06
chore(deps-dev): bump @typescript-eslint/eslint-plugin (#75)
dependabot[bot] 034fa81
chore(deps-dev): bump webidl2 from 23.13.0 to 23.13.1 (#72)
dependabot[bot] 0e44eb7
chore(deps-dev): bump @types/node from 14.14.27 to 14.14.31 (#73)
dependabot[bot] 39b3171
chore(deps-dev): bump @typescript-eslint/parser from 4.15.2 to 4.16.0…
dependabot[bot] d0728b0
feat(types): update bcd to 3.1.3
saschanaz 415da69
chore(package): bump version number to v0.1.8
saschanaz 5634c07
chore(types): remove now-redundant exposure overriding
saschanaz 9c75780
fix(types): return FileSystemEntry from webkitGetAsEntry()
saschanaz 3def312
feat(changelog): infer the base commit
saschanaz 2457c0a
feat(changelog): explicitly fail when there is no reportable change
saschanaz 5ab8e93
chore(dependabot): update important deps daily
saschanaz b4b6bbf
chore(types): update bcd to v3.2.0
saschanaz 3d783b2
Revert "chore(dependabot): update important deps daily"
saschanaz 6186734
chore(package): update webref (#82)
github-actions[bot] d67702b
chore(deps-dev): bump browser-specs from 1.28.0 to 1.30.0 (#80)
dependabot[bot] a5d0b07
chore(deps-dev): bump typescript from 4.2.2 to 4.2.3 (#84)
dependabot[bot] 34e3b27
chore(package): update deps
saschanaz 3356c96
chore(package): update deps
saschanaz 3a24bfa
chore(package): migrate to webidl packages
saschanaz b8a56a3
chore(build): remove redundant denylist items
saschanaz 4ef63f6
chore(package): update webref (#86)
github-actions[bot] 65f4f65
chore(package): update deps
saschanaz c08fd72
chore(package): update deps
saschanaz 860e3e7
style: remove prettier config override
saschanaz 9a4d336
chore(package): update
saschanaz 933c22d
feat(emitter): support differing accessor types (#88)
saschanaz 6bd4918
feat(types): update webref/idl to 2.0.0, etc.
saschanaz 05e0a90
chore(package): bump version number to v0.1.9
saschanaz 87021dc
chore(package): update deps
saschanaz 276da88
feat(types): add clipboard binary methods
saschanaz b32712d
chore(package): bump version number to v0.1.10
saschanaz 6b32439
feat(types): update bcd to v3.3.2
saschanaz 73542a7
chore(package): bump version number to v0.1.11
saschanaz 77050b1
chore(deps-dev): bump typescript (#96)
dependabot[bot] b169ebb
chore(types): update deps
saschanaz 0f24f76
Split as interface from signature
saschanaz 05cbd93
chore(bcd): split as shouldStyleBeRemoved()
saschanaz 82fbfeb
refactor(bcd): split forceKeepAlive
saschanaz 87dd612
refactor(bcd): split mapInterfaceLike
saschanaz da12590
feat(bcd): resolve compat data for mixin members
saschanaz 3d88f14
chore(package): bump version number to v0.1.12
saschanaz 0c5fbbf
chore(changelog): update
saschanaz 148b083
chore(package): update webref (#97)
github-actions[bot] f2a93cf
chore(package): bump version number to 0.1.13
saschanaz 33caefc
chore(workflows): update-core-deps
saschanaz 70ba5e0
chore(package): update core dependencies (#98)
github-actions[bot] 80fb08f
chore(package): bump version number to 0.1.14
saschanaz 69e842f
feat(workflows): try updating all deps
saschanaz d3dfe92
style: apply updated prettier
saschanaz a6fb2dc
chore(package): update deps
saschanaz 84aa732
chore(package): update core dependencies (#104)
github-actions[bot] 8e475e1
chore(bcd): remove redundant keepalive items
saschanaz f50eeeb
feat(bcd): use @webref/elements
saschanaz 06207b4
chore(package): bump version number to 0.1.15
saschanaz f40e338
fix(build): remove local idls
saschanaz 3ba381f
fix(build): sort mixin list
saschanaz 19c6039
refactor(webref): drop browser-specs
saschanaz 589ee43
chore(package): bump version number to 0.1.16
saschanaz 5ff34fc
chore(package): update core dependencies (#105)
github-actions[bot] 44af381
feat(package): add version hook
saschanaz 640ada9
chore(package): bump version number to v0.1.17
saschanaz ab95065
chore(workflows): use PAT for pull request
saschanaz 6ef3251
chore(package): update core dependencies (#106)
github-actions[bot] 0fab4e6
fix(changelog): no whitespace when no addition/removal
saschanaz 5f78617
chore(package): bump version number to v0.1.18
saschanaz 4342980
chore(package): update core dependencies (#107)
saschanaz 6b44938
chore(package): bump version number to v0.1.19
saschanaz 7b2675f
chore(package): make sure installed packages match the versions
saschanaz 850b7eb
Adds aliases for renamed HTML elements (#108)
orta 7704232
Remove the readonly attribute on all prototype (#109)
orta 91408ba
Adds some more backwards-compat dummy interfaces (#114)
orta be147c6
fix(build/widlprocess): .inherit is replaced by .special
saschanaz 7e6fbde
chore(build/bcd): remove redundant items
saschanaz d1ff27f
chore(package): update bcd to 0.3.9
saschanaz 785ee82
chore(package): update webref/idl to 2.2.4
saschanaz f3b86f5
chore(package): update webidl2.js to 24.1.2
saschanaz dec51c4
chore(package-lock): update
saschanaz 5288d88
refactor(build/emitter): simplify tryEmitTypedEventHandlerForInterface
saschanaz 25a2c27
Merge upstream
orta 40e10bb
Bring back the EventListenerOrEventListenerObject and EventListener a…
orta 1b8d3e1
chore(package): update core dependencies (#116)
saschanaz d384b28
Adds stylemedia back (#113)
orta a340b80
Add back ClientRect (#112)
orta 887c60c
Update README.md
a88f594
Merge main
orta 3976f06
More merging
orta 619d4e8
Merge branch 'merge_types_web' of https://github.com/microsoft/TypeSc…
orta 6c61dab
Add back migrate script
orta bc40006
Fix packages
orta 01e8285
Update the bot
orta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Basic dependabot.yml file | ||
# https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/enabling-and-disabling-version-updates | ||
|
||
version: 2 | ||
updates: | ||
# Enable version updates for npm | ||
- package-ecosystem: "npm" | ||
# Look for `package.json` and `lock` files in the `root` directory | ||
directory: "/" | ||
# Check the npm registry for updates every month | ||
schedule: | ||
interval: "monthly" | ||
# Bump versions in package.json | ||
# https://github.com/dependabot/dependabot-core/issues/3103 | ||
# https://docs.github.com/en/github/administering-a-repository/configuration-options-for-dependency-updates#versioning-strategy | ||
versioning-strategy: "increase" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,6 @@ jobs: | |
with: | ||
node-version: '15' | ||
|
||
- run: npm install | ||
- run: npm ci | ||
- run: npm run build | ||
- run: npm test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
name: Update core dependencies | ||
on: | ||
workflow_dispatch: | ||
schedule: | ||
# https://crontab.guru/#5_8_*_*_* | ||
- cron: "5 8 * * *" | ||
|
||
# Conditional runs | ||
# https://stackoverflow.com/a/61832535/2460034 | ||
jobs: | ||
update-webref: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: '15' | ||
|
||
- run: npm i -g npm-check-updates | ||
- run: ncu -u | ||
- run: npm i | ||
- run: npm run build && npm run baseline-accept | ||
- id: git-diff | ||
run: git diff --quiet HEAD baselines | ||
continue-on-error: true | ||
- uses: peter-evans/create-pull-request@v3 | ||
if: ${{ steps.git-diff.outcome == 'failure' }} | ||
with: | ||
commit-message: "chore(package): update core dependencies" | ||
title: "chore(package): update core dependencies" | ||
branch: update-core-deps | ||
token: ${{ secrets.TS_GITHUB_BOT_AUTH }} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
package-lock=false | ||
message="chore(package): bump version number to v%s" |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,12 @@ | ||
# TypeScript and JavaScript lib generator | ||
|
||
Travis CI Status: [![Build Status](https://travis-ci.org/Microsoft/TSJS-lib-generator.svg?branch=master)](https://travis-ci.org/Microsoft/TSJS-lib-generator) | ||
This tool is used to generate the web-based `lib.dom.d.ts` file which is included with TypeScript releases, and as the `@types/web` package. | ||
|
||
This tool is used to generate `dom.generated.d.ts`, `webworker.generated.d.ts` and `dom.iterable.generated.d.ts` for TypeScript. | ||
The input file is the JSON webidl file generated by the Microsoft Edge browser. | ||
## Why is my fancy API still not available here? | ||
|
||
A feature needs to be supported by more than two major browser engines to be included here, to make sure there is a good consensus among vendors: __Gecko__ (Firefox), __Blink__ (Chrome/Edge), and __WebKit__ (Safari). | ||
|
||
If the condition is met but still is not available here, please [file an issue](hthttps://github.com/microsoft/TypeScript-DOM-lib-generator/issues/new). | ||
|
||
## Build Instructions | ||
|
||
|
@@ -53,11 +56,10 @@ The format of each file can be inferred from their existing content. | |
|
||
The common steps to send a pull request are: | ||
|
||
0. Open or refer to an issue in the [TypeScript repo](https://github.com/Microsoft/TypeScript). | ||
1. Add missing elements to `inputfiles/addedTypes.json`, overriding elements to `inputfiles/overridingTypes.json`, or elements to remove to `inputfiles/removedTypes.json`. | ||
0. Open or refer to an issue in the [TypeScript repo](https://github.com/Microsoft/TypeScript) which might get moved back to this repo. | ||
1. Update an IDL or add missing elements to `inputfiles/addedTypes.json`, overriding elements to `inputfiles/overridingTypes.json`, or elements to remove to `inputfiles/removedTypes.json`. | ||
2. Run the build script locally to obtain new `dom.generated.d.ts` and `webworker.generated.d.ts`. | ||
3. Update the files in the `baselines` folder using the newly generated files | ||
under `generated` folder (`npm run baseline-accept`). | ||
3. Update the files in the `baselines` folder using the newly generated files under `generated` folder (`npm run baseline-accept`). | ||
|
||
### What are the TypeScript team's heuristics for PRs to the DOM APIs | ||
|
||
|
@@ -95,6 +97,8 @@ To give you a sense of whether we will accept changes, you can use these heurist | |
- Does an internet search for the fields show results in blogs/recommendations? | ||
- When was the deprecation (this can be hard to find) but was it at least 2 years ago if so? | ||
|
||
## Build Instructions | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this looks unfinished There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looks it was a merge error - this is a dupe from the top |
||
|
||
# This repo | ||
|
||
## Code Structure | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was 'two or more'.