Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebAssembly): Correct NativeError subclass types #962

Merged

Conversation

ExE-Boss
Copy link
Contributor

These types are actually defined using ECMA‑262’s NativeError object structure:


They’re also exposed everywhere namespace WebAssembly is.

@saschanaz
Copy link
Contributor

#1034 included this fix

@github-actions close

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2021

Closing because @saschanaz is a code-owner of all the changes.

@github-actions github-actions bot closed this Sep 4, 2021
@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Sep 4, 2021

@saschanaz Actually, the type declarations of #1034 are still wrong, because the constructors still lack the message parameter and callable signatures:

interface CompileError extends Error {
}
var CompileError: {
prototype: CompileError;
new(): CompileError;
};
interface LinkError extends Error {
}
var LinkError: {
prototype: LinkError;
new(): LinkError;
};
interface RuntimeError extends Error {
}
var RuntimeError: {
prototype: RuntimeError;
new(): RuntimeError;
};

@saschanaz
Copy link
Contributor

Ah yeah, seems you are right. Feel free to reopen and rebase.

@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Sep 4, 2021

I can’t reopen this PR myself, because I’m not the one who closed it and my account doesn’t have the necessary permissions to reopen PRs closed by org members or collaborators in this repository.

@saschanaz
Copy link
Contributor

Mind rebasing this? 👀

@ExE-Boss ExE-Boss force-pushed the types/wasm/fix-native-error-subclasses branch from 03c5225 to dc36038 Compare September 20, 2021 06:30
@saschanaz
Copy link
Contributor

LGTM

@github-actions
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

@github-actions github-actions bot merged commit c7f8137 into microsoft:main Sep 24, 2021
@ExE-Boss ExE-Boss deleted the types/wasm/fix-native-error-subclasses branch September 24, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants