-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(WebAssembly): Correct NativeError
subclass types
#962
fix(WebAssembly): Correct NativeError
subclass types
#962
Conversation
#1034 included this fix @github-actions close |
Closing because @saschanaz is a code-owner of all the changes. |
@saschanaz Actually, the type declarations of #1034 are still wrong, because the constructors still lack the TypeScript-DOM-lib-generator/baselines/dom.generated.d.ts Lines 17716 to 17722 in 01e8285
TypeScript-DOM-lib-generator/baselines/dom.generated.d.ts Lines 17743 to 17749 in 01e8285
TypeScript-DOM-lib-generator/baselines/dom.generated.d.ts Lines 17772 to 17778 in 01e8285
|
Ah yeah, seems you are right. Feel free to reopen and rebase. |
I can’t reopen this PR myself, because I’m not the one who closed it and my account doesn’t have the necessary permissions to reopen PRs closed by org members or collaborators in this repository. |
Mind rebasing this? 👀 |
03c5225
to
dc36038
Compare
LGTM |
Merging because @saschanaz is a code-owner of all the changes - thanks! |
These types are actually defined using ECMA‑262’s
NativeError
object structure:They’re also exposed everywhere
namespace WebAssembly
is.