Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Not clear why skipDefaultLibCheck recommends skipLibCheck instead #2781

Closed
victorlin opened this issue Apr 10, 2023 · 1 comment
Closed

Comments

@victorlin
Copy link

Page URL:

https://www.typescriptlang.org/tsconfig#skipDefaultLibCheck (source)

Issue:

This is the current description of skipDefaultLibCheck:

Use skipLibCheck instead. Skip type checking of default library declaration files.

The recommendation to use skipLibCheck doesn't come with a meaningful reason.

In my experience, this flag still has an effect even when skipLibCheck is unset. For one project, I am averaging 0.92s when skipDefaultLibCheck=false (default) and 0.61s when skipDefaultLibCheck=true. Because of this, I have a clear use case for using skipDefaultLibCheck but not skipLibCheck.

Recommended Fix:

Remove the suggestion and clarify the difference between skipLibCheck and skipDefaultLibCheck.

@typescript-bot
Copy link
Collaborator

Hello! As per #2804, we are automatically closing all open issues. Please see #2804 for a description of what issues and PRs can be accepted going forward.

@typescript-bot typescript-bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants