Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isolatedModules docs to match 5.0+ behavior #2951

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Update isolatedModules docs to match 5.0+ behavior #2951

merged 2 commits into from
Oct 3, 2023

Conversation

iisaduan
Copy link
Member

@iisaduan iisaduan commented Oct 2, 2023

iisaduan
iisaduan commented Oct 2, 2023
View reviewed changes
packages/tsconfig-reference/copy/en/options/isolatedModules.md

```ts twoslash
// @errors: 1208
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if we should add that this error is now made by moduleDetection: "force"

andrewbranch
andrewbranch approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewbranch
Copy link
Member

Feel free to merge any time. Once CI finishes, you’ll get a preview deployment if you want to check that it looks right.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-glacier-09aa73710-2951.centralus.azurestaticapps.net

@iisaduan iisaduan merged commit 9150ed6 into v2 Oct 3, 2023
6 checks passed
@iisaduan iisaduan deleted the isolatedModules-nonModule-docs branch October 3, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isolatedModules documentation still says that it bans non-modules
2 participants
@iisaduan @andrewbranch