Assigning window.location after 5.8.2 upgrade fails

[AndreasPresthammer]

🔎 Search Terms

Unable to assign window.location typescript 5.8.2
error TS2322: Type 'Location' is not assignable to type 'string & Location'.
Type 'Location' is not assignable to type 'string'.

🕗 Version & Regression Information

• This changed between versions 5.7.3 and 5.8.2

⏯ Playground Link

https://www.typescriptlang.org/play/?ts=5.8.2#code/O4SwdgJg9sB0A2UDGBDALiKYAEBebokMCy6mYA3AFBA

💻 Code

window.location = window.location;

🙁 Actual behavior

Failing with error:

error TS2322: Type 'Location' is not assignable to type 'string & Location'.
  Type 'Location' is not assignable to type 'string'.

🙂 Expected behavior

Expect it to either be a documented breaking change, OR it should continue to work as it did in 5.7.3:

https://www.typescriptlang.org/play/?ts=5.7.3#code/O4SwdgJg9sB0A2UDGBDALiKYAEBebokMCy6mYA3AFBA

Additional information about the issue

No response

[MartinJohns]

Related: #48949

[chrisvltn]

Had the same issue when upgrading to the new version.

A similar workaround to this one worked for me:

const win: typeof globalThis = window;
win.location = window.location; // Pass

---

I see the PR #60987 added this part:

Document.location and Window.location now has stricter get/set types:

• get location(): Location is unchanged
• set location(href: string) previously allowed Location (probably because of Typescript's accessor assignability rules)

Seems to be the cause of the change, as set location expects a string, but globalThis['location'] expects a Location

[reifi]

A pain for old style iframe prevention - ts-ignore helps

if (window.top !== window.self) {
  if (window.top) {  
    // @ts-ignore
    window.top.location = window.self.location;
  }
}