Skip to content

Commit e06ade0

Browse files
danielmeppieldanielmeppiel
authored
Merge pull request #118 from microsoft/chore/governance-cleanup
chore: governance cleanup - templates, triage labels, changelog, roadmap
2 parents 1849009 + 980303f commit e06ade0

11 files changed

Lines changed: 57 additions & 173 deletions

File tree

‎.github/ISSUE_TEMPLATE/bug_report.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name: Bug report
33
about: Create a report to help us improve
44
title: '[BUG] '
5-
labels: bug
5+
labels: bug, needs-triage
66
assignees: ''
77

88
---

‎.github/ISSUE_TEMPLATE/feature_request.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name: Feature request
33
about: Suggest an idea for this project
44
title: '[FEATURE] '
5-
labels: enhancement
5+
labels: enhancement, needs-triage
66
assignees: ''
77

88
---

‎.github/ISSUE_TEMPLATE/init-install-redesign.md‎

Lines changed: 0 additions & 9 deletions
This file was deleted.

‎.github/PULL_REQUEST_TEMPLATE/bugfix.md‎

Lines changed: 0 additions & 25 deletions
This file was deleted.

‎.github/PULL_REQUEST_TEMPLATE/documentation.md‎

Lines changed: 0 additions & 24 deletions
This file was deleted.

‎.github/PULL_REQUEST_TEMPLATE/feature.md‎

Lines changed: 0 additions & 27 deletions
This file was deleted.

‎.github/PULL_REQUEST_TEMPLATE/maintenance.md‎

Lines changed: 0 additions & 29 deletions
This file was deleted.

‎.github/pull_request_template.md‎

Lines changed: 6 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,18 @@
1-
# Pull Request
2-
3-
## ⚡ Quick Start - Use Specialized Templates
4-
5-
For better guidance, consider using our specialized templates:
6-
7-
- **🚀 New Feature**: [Create Feature PR](https://github.com/microsoft/apm/compare/main...HEAD?template=feature.md)
8-
- **🐛 Bug Fix**: [Create Bug Fix PR](https://github.com/microsoft/apm/compare/main...HEAD?template=bugfix.md)
9-
- **📖 Documentation**: [Create Docs PR](https://github.com/microsoft/apm/compare/main...HEAD?template=documentation.md)
10-
- **🔧 Maintenance**: [Create Maintenance PR](https://github.com/microsoft/apm/compare/main...HEAD?template=maintenance.md)
11-
121
## Description
132

143
Brief description of changes and motivation.
154

16-
## Type of Change
5+
Fixes # (issue)
176

18-
**🏷️ IMPORTANT: Apply the appropriate label after creating this PR:**
7+
## Type of change
198

20-
- [ ] 🚀 **New Feature** → Apply label: `enhancement` or `feature`
21-
- [ ] 🐛 **Bug Fix** → Apply label: `bug` or `fix`
22-
- [ ] 📖 **Documentation** → Apply label: `documentation` or `docs`
23-
- [ ] 🔧 **Other Changes** → No specific label needed
24-
- [ ] 🚫 **Exclude from Release Notes** → Apply label: `ignore-for-release`
9+
- [ ] Bug fix
10+
- [ ] New feature
11+
- [ ] Documentation
12+
- [ ] Maintenance / refactor
2513

2614
## Testing
2715

2816
- [ ] Tested locally
2917
- [ ] All existing tests pass
3018
- [ ] Added tests for new functionality (if applicable)
31-
32-
## Checklist
33-
34-
- [ ] **✅ LABEL APPLIED**: I have applied the appropriate label to this PR
35-
- [ ] Code follows project style guidelines
36-
- [ ] Updated documentation if needed
37-
- [ ] Updated CHANGELOG.md for significant changes
38-
39-
Fixes # (issue)

‎CHANGELOG.md‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,33 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

88

9+
## [Unreleased]
10+
11+
### Added
12+
13+
- **Deploy Agents**: Agents now install to `.claude/agents/` during `apm install` (#95)
14+
- **Sub-skill Promotion**: Promote sub-skills inside packages to top-level `.github/skills/` entries (#102)
15+
- **Agentic Workflows**: GitHub Agentic Workflows for docs, testing, and CLI consistency (#104)
16+
17+
### Changed
18+
19+
- **Microsoft OSPO Transfer**: Migrated to Microsoft OSS organization (#85, #105)
20+
- **README**: Added missing version field in the apm.yml example (#108)
21+
- **CI**: Slim PR pipelines to Linux-only for fast feedback (#103)
22+
- **CI**: Auto-approve integration tests for internal PRs (#98)
23+
- **CODEOWNERS**: Added code ownership file (#115)
24+
25+
### Fixed
26+
27+
- **Workflow Permissions**: Fixed GitHub Actions permissions (#87)
28+
- **Azure DevOps**: Support spaces in project names (#92)
29+
- **Virtual Subdirectory Deps**: Fix virtual subdirectory deps marked as orphaned, skipping instruction processing (#100)
30+
- **CI**: Prevent skip-propagation in integration test pipeline (#106)
31+
- **Skill Integration**: Fix skill integration bugs, transitive dep cleanup, and simplification (#107)
32+
- **CI**: Integration test corrections (#109)
33+
- **Transitive Dependencies**: Fix transitive dependency handling in compile and orphan detection (#111)
34+
35+
936
## [0.7.3] - 2025-02-15
1037

1138
### Added

‎CONTRIBUTING.md‎

Lines changed: 18 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -43,26 +43,21 @@ Enhancement suggestions are welcome! Please:
4343

4444
### Pull Request Process
4545

46-
1. **Choose the appropriate PR template** for your change:
47-
- **🚀 New Feature**: Use the `feature.md` template
48-
- **🐛 Bug Fix**: Use the `bugfix.md` template
49-
- **📖 Documentation**: Use the `documentation.md` template
50-
- **🔧 Maintenance**: Use the `maintenance.md` template
51-
- **Other**: Use the standard PR template
52-
53-
2. **Apply the correct label** after creating your PR:
54-
- `enhancement` or `feature` - New functionality
55-
- `bug` or `fix` - Bug fixes
56-
- `documentation` or `docs` - Documentation updates
57-
- `ignore-for-release` - Exclude from release notes
58-
59-
3. Follow the template provided.
60-
4. Ensure your PR addresses only one concern (one feature, one bug fix).
61-
5. Include tests for new functionality.
62-
6. Update documentation if needed.
63-
7. PRs must pass all checks before they can be merged.
64-
65-
**Note**: Labels are used to automatically categorize changes in release notes. The correct label helps maintainers and users understand what changed in each release.
46+
1. Fill out the PR template — describe what changed, why, and link the issue.
47+
2. Ensure your PR addresses only one concern (one feature, one bug fix).
48+
3. Include tests for new functionality.
49+
4. Update documentation if needed.
50+
5. PRs must pass all CI checks before they can be merged.
51+
52+
### Issue Triage
53+
54+
Every new issue is automatically labeled `needs-triage`. Maintainers review incoming issues and:
55+
56+
1. **Accept** — remove `needs-triage`, add `accepted`, and assign a milestone.
57+
2. **Prioritize** — optionally add `priority/high` or `priority/low`.
58+
3. **Close** — if it's a duplicate (`duplicate`) or out of scope, close with a comment explaining why.
59+
60+
Labels used for triage: `needs-triage`, `accepted`, `needs-design`, `priority/high`, `priority/low`.
6661

6762
## Development Environment
6863

@@ -73,22 +68,15 @@ This project uses uv to manage Python environments and dependencies:
7368
git clone <this-repo-url>
7469
cd apm
7570

76-
# Create a virtual environment and install dependencies
77-
uv venv
78-
source venv/bin/activate # On Windows, use: venv\Scripts\activate
79-
uv pip install -e ".[dev]"
71+
# Install all dependencies (creates .venv automatically)
72+
uv sync --extra dev
8073
```
8174

8275
## Testing
8376

84-
We use pytest for testing. The project uses `uv` to manage virtual environments and dependencies — the recommended way to run tests is:
77+
We use pytest for testing. After completing the setup above, run the test suite with:
8578

8679
```bash
87-
uv run pytest
88-
# install dev dependencies (creates .venv managed by uv)
89-
uv sync --extra dev
90-
91-
# run the test suite
9280
uv run pytest -q
9381
```
9482

0 commit comments

Comments
 (0)