diff --git a/CHANGELOG.md b/CHANGELOG.md index 972778fa1..efbfddf62 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,11 @@ # App Center SDK for Android Change Log ## Version 5.0.5 (Under development) -w + +### App Center Crashes + +* **[Fix]** Synchronize the timestamp used for minidump attachments with the crash log's timestamp. + ## Version 5.0.4 ### App Center Distribute diff --git a/sdk/appcenter-crashes/src/main/java/com/microsoft/appcenter/crashes/Crashes.java b/sdk/appcenter-crashes/src/main/java/com/microsoft/appcenter/crashes/Crashes.java index 024b2e459..5a0dc96ac 100644 --- a/sdk/appcenter-crashes/src/main/java/com/microsoft/appcenter/crashes/Crashes.java +++ b/sdk/appcenter-crashes/src/main/java/com/microsoft/appcenter/crashes/Crashes.java @@ -1044,6 +1044,7 @@ public void run() { dumpFile = new File(minidumpFilePath); byte[] logfileContents = FileManager.readBytes(dumpFile); dumpAttachment = ErrorAttachmentLog.attachmentWithBinary(logfileContents, "minidump.dmp", "application/octet-stream"); + dumpAttachment.setTimestamp(errorLogReport.log.getTimestamp()); } else { AppCenterLog.warn(LOG_TAG, "NativeException found without minidump."); } diff --git a/sdk/appcenter-crashes/src/test/java/com/microsoft/appcenter/crashes/CrashesTest.java b/sdk/appcenter-crashes/src/test/java/com/microsoft/appcenter/crashes/CrashesTest.java index 975c75cdc..0191ca10c 100644 --- a/sdk/appcenter-crashes/src/test/java/com/microsoft/appcenter/crashes/CrashesTest.java +++ b/sdk/appcenter-crashes/src/test/java/com/microsoft/appcenter/crashes/CrashesTest.java @@ -1366,12 +1366,15 @@ public ManagedErrorLog answer(InvocationOnMock invocation) { ManagedErrorLog log = mock(ManagedErrorLog.class); when(log.getId()).thenReturn(UUID.randomUUID()); when(log.getException()).thenReturn(exception); + when(log.getTimestamp()).thenReturn(new Date()); return log; } }); when(logSerializer.serializeLog(any(Log.class))).thenReturn(jsonCrash); when(SharedPreferencesManager.getBoolean(CRASHES_ENABLED_KEY, true)).thenReturn(true); + ErrorAttachmentLog errorAttachmentLog = mock(ErrorAttachmentLog.class); + when(ErrorAttachmentLog.attachmentWithBinary(any(), anyString(), anyString())).thenReturn(mock(ErrorAttachmentLog.class)); whenNew(ErrorAttachmentLog.class).withAnyArguments().thenReturn(errorAttachmentLog); /* Start crashes. */