Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outdated use of summary_prompt in tutorial. #2657

Closed
ekzhu opened this issue May 10, 2024 · 4 comments
Closed

Fix outdated use of summary_prompt in tutorial. #2657

ekzhu opened this issue May 10, 2024 · 4 comments
Assignees
@pk673
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ekzhu
Copy link
Collaborator

ekzhu commented May 10, 2024

In the tutorial page: https://microsoft.github.io/autogen/docs/tutorial/conversation-patterns

There are several examples of using summary_prompt however the code is outdated as summary_prompt is not the top-level argument anymore, it should be:

{
    "recipient": group_chat_manager_with_intros,
    "summary_method": "reflection_with_llm",
    "summary_args":  {"summary_prompt": "Summarize the sequence of operations used to turn " "the source number into target number."},
},

Would you like to help fixing this?

Originally posted by @ekzhu in #2621 (comment)
@ekzhu ekzhu added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels May 10, 2024
@pk673
Copy link
Contributor

pk673 commented May 11, 2024

@ekzhu I would love to work on this, could you please assign this to me. thanks!

@ekzhu
Copy link
Collaborator Author

ekzhu commented May 11, 2024

@pk673 just assigned. Thanks!

@prithvi2226
Copy link
Contributor

Hey @ekzhu! Has this issue been solved? Thanks!

neha26pp added a commit to neha26pp/autogen that referenced this issue Jun 3, 2024
@neha26pp
Update conversation-patterns.ipynb
d340334 
summary_prompt is no longer a top level argument. 
microsoft#2657
@neha26pp neha26pp mentioned this issue Jun 3, 2024
Closed
3 tasks
@ekzhu
Copy link
Collaborator Author

ekzhu commented Aug 27, 2024

Hey @ekzhu! Has this issue been solved? Thanks!

Yes

@ekzhu ekzhu closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pk673 pk673

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update conversation-patterns.ipynb neha26pp/autogen
3 participants
@ekzhu @prithvi2226 @pk673