Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: some configurations in .devcontainers are out of date/wrong #2986

Open
WHALEEYE opened this issue Jun 21, 2024 · 0 comments
Open

[Issue]: some configurations in .devcontainers are out of date/wrong #2986

WHALEEYE opened this issue Jun 21, 2024 · 0 comments
Labels
dev development experience/productivity docker Issues relating to Docker

Comments

@WHALEEYE
Copy link

Describe the issue

There are some wrong/out of date configurations in the Dockerfiles under .devcontainers.

  • All the base images in these Dockerfiles (python:3.10 and python:3.11-sim-bookworm) can already install the git-lfs through apt-get directly without adding these manually. Therefore this line is actually out of date
# add git lhs to apt
RUN curl -s https://packagecloud.io/install/repositories/github/git-lfs/script.deb.sh | bash

(Also, the typo here is not totally fixed. There's still typo in the comment)

  • The base image, python:3.11-slim-bookworm, which is used in dev and full Dockerfiles, does not comes with curl ready to use, which means that this configuration for these two images
# add git lhs to apt
RUN curl -s https://packagecloud.io/install/repositories/github/git-lfs/script.deb.sh | bash

actually fails silently (the output was redirected, which I think could be the reason). This made me very confused when I was trying to modify the Dockerfile and I think this one should be deleted.

  • Also, I'm not quite understand why different base images are used for different versions. Is there any reason behind this?

Steps to reproduce

No response

Screenshots and logs

No response

Additional Information

No response

@Hk669 Hk669 added dev development experience/productivity docker Issues relating to Docker labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev development experience/productivity docker Issues relating to Docker
Projects
None yet
Development

No branches or pull requests

2 participants