You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If dependencies within the repo are specified as workspace:*, workspace:^, or workspace:~, this causes dependent bumps to be missed from the changelog (only) because the version range doesn't change.
(The actual package versions are still bumped by updateRelatedChangeType, and the workspace: dependencies will be replaced with the current versions during publishing; the Bump X to Y entries are just missing from the changelog.)
BumpInfo.dependentChangedBy is the property that's used to generate the Bump X to Y entries. It's generated here:
This is the bumping logic for workspace:*/^/~ ranges in dependencies. Since the string never changes, the dependent bump won't be included in dependentChangedBy above.
Possibly this could be fixed by passing modifiedPackages through to setDependentVersions and adding an extra condition to the check in setDependentVersions (for deps with those workspace versions).
The text was updated successfully, but these errors were encountered:
ecraig12345
changed the title
Dependent bumps are missed with workspace: versions
Dependent bumps are missing from changelog with workspace: versions
Sep 6, 2024
If dependencies within the repo are specified as
workspace:*
,workspace:^
, orworkspace:~
, this causes dependent bumps to be missed from the changelog (only) because the version range doesn't change.(The actual package versions are still bumped by
updateRelatedChangeType
, and theworkspace:
dependencies will be replaced with the current versions during publishing; theBump X to Y
entries are just missing from the changelog.)BumpInfo.dependentChangedBy
is the property that's used to generate theBump X to Y
entries. It's generated here:beachball/src/bump/setDependentVersions.ts
Lines 28 to 33 in dbdde9c
This is the bumping logic for
workspace:*/^/~
ranges in dependencies. Since the string never changes, the dependent bump won't be included independentChangedBy
above.beachball/src/bump/bumpMinSemverRange.ts
Lines 7 to 11 in dbdde9c
Possibly this could be fixed by passing
modifiedPackages
through tosetDependentVersions
and adding an extra condition to the check insetDependentVersions
(for deps with those workspace versions).beachball/src/bump/bumpInPlace.ts
Lines 52 to 53 in dbdde9c
The text was updated successfully, but these errors were encountered: