Check renamed change files #580
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arazabishov
reviewed
Aug 21, 2021
| @@ -17,12 +17,12 @@ export function areChangeFilesDeleted(options: BeachballOptions): boolean { | |||
| process.exit(1); | |||
| } | |||
|
|
|||
| console.log(`Checking for deleted change files against "${branch}"`); | |||
| console.log(`Checking for deleted and renamed change files against "${branch}"`); | |||
There was a problem hiding this comment.
I think it would make sense to rename the function too: areChangeFilesDeletedOrRenamed. A bit on verbose side, but reflects the purpose of the function :)
There was a problem hiding this comment.
I suppose that would be more descriptive. However, it will break the API. There are a couple of options I can see to avoid this:
- Create a new more descriptive function while keeping the current one and marking it for deprecation in the future.
- Create a new method that just checks for renamed change files and calling it based on a flag like
--disallow-renamed-change-fileswhich can be used in conjunction with the current function.
Which option should we go with - or are there other options?
There was a problem hiding this comment.
I think option #2 makes more sense :)
There was a problem hiding this comment.
@LarryKiniu This is an internal API, so you don't need to worry about breaking it. (I'm fine with either renaming the function or just going with this as-is.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks whether change files have been renamed and might solve #579