-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release types for major and minor prereleases #944
Add release types for major and minor prereleases #944
Conversation
This makes sense but would probably be perceived as a breaking change in a lot of repos that use beachball today, since suddenly several new change types would be available and have to be manually added to their In the meantime, I think a workaround would be to revert the |
@ecraig12345 Alright, I removed the other pre* versions from the prompt. Is that something that can be added in a minor/patch release in this way or do I need to make other changes to ensure we don't break current implementation? I could optionally also disallow them all if prerelease is disallowed, but that may be a hacky solution? |
@kjellknapen I think it's fine if new change types are allowed by default as long as they don't show up in the prompt. I ran a build and it looks like you'll also need to update |
@ecraig12345 Done! Thanks for the quick response. I used the same title as the respective versions but added (pre-release) behind them. |
Looks like you accidentally installed with pnpm (this repo uses yarn)--can you delete the pnpm lock file? |
Oops my bad, was working in a different project with pnpm, so I was in that flow. I removed it |
Oh I guess you need a change file too. |
I guess I need to update some tests aswell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ecraig12345 Does the test failing here signal that my changes are still breaking?
@ecraig12345 Had any time to review this once more? Tests should work now |
Allow user to do prereleases of major and minor releases. It's very weird that isn't a possibility right now.