Remove dependents from BumpInfo + use shared dep type list #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
force-pushed
the
ecraig/bump-info-dependents
branch
from
db7e750
to
8c0a150
Compare
ecraig12345
changed the title
ecraig12345
force-pushed
the
ecraig/bump-info-dependents
branch
from
a0bf699
to
e09f662
Compare
ecraig12345
force-pushed
the
ecraig/bump-info-dependents
branch
from
e09f662
to
1e82c2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dependentsproperty ofBumpInfowas only used inbumpInPlaceand its immediate child functions. This PR removes it fromBumpInfoand passes it as a parameter instead (working towards untangling theBumpInfoside effect spaghetti).Also update
updateRelatedChangeTypeto take object parameters.From merging in an old version of this change, I noticed that we have multiple places in the code with a list of dep types considered for bumping. So I added an array constant and updated everywhere to use it.