Remove redundant BumpInfo.groupOptions #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
force-pushed
the
ecraig/bump-info-groups
branch
from
8f76d5e
to
7539a62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only place
BumpInfo.groupOptionswas used, it was accessing info redundant withBumpInfo.packageGroups. So removegroupOptionsand update usage.Move the initialization of
BumpInfo.packageGroupsfrom a side effect inbumpInPlaceto instead be handled during bump info object initialization ingatherBumpInfo, for clarity.Also add and start using a
DeepReadonlytype to indicate where objects are not mutated. This is again a step towards untangling the side effect spaghetti.