Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#6841] SkillDialog.InterceptOAuthCardsAsync doesn't support CloudAdapter #4741

Closed
ceciliaavila opened this issue Sep 10, 2024 · 0 comments · Fixed by #4766
Closed

port: [#6841] SkillDialog.InterceptOAuthCardsAsync doesn't support CloudAdapter #4741

ceciliaavila opened this issue Sep 10, 2024 · 0 comments · Fixed by #4766
Assignees
@ceciliaavila
Labels
bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@ceciliaavila
Copy link
Collaborator

The changes in [#6841] SkillDialog.InterceptOAuthCardsAsync doesn't support CloudAdapter may need to be ported to maintain parity with microsoft/botbuilder-js.

Fixes #6841

Description

This PR updates the InterceptOAuthCardsAsync method in SkillDialog to support CloudAdapter in combination with expect replies delivery mode.

Specific Changes

  • In InterceptOAuthCardsAsync added a call to UserTokenAccess.ExchangeTokenAsync method, which handles both adapters.

Testing

This image shows the token exchanged for SSO using CloudAdapter and expect replies.
image
@ceciliaavila ceciliaavila added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Sep 10, 2024
@ceciliaavila ceciliaavila self-assigned this Sep 10, 2024
@ceciliaavila ceciliaavila mentioned this issue Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Milestone
No milestone
1 participant
@ceciliaavila