Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog merge results should include iconUrl if present in component #1179

Open
benbrown opened this issue Apr 5, 2021 · 0 comments
Open

Dialog merge results should include iconUrl if present in component #1179

benbrown opened this issue Apr 5, 2021 · 0 comments

Comments

@benbrown
Copy link
Contributor

benbrown commented Apr 5, 2021

Is your feature request related to a problem? Please describe.

When using the dialog merge command, the results currently include the PackageIcon field from dotnet components. This value is typically a relative path, not an absolute URL, thus not usable in Composer.

See: microsoft/botframework-components#802

Describe the solution you'd like

Please include the PackageIconUrl field if included in the csproj file. Ideally this would be included as iconUrl in the results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benbrown