Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bf luis:cross-train should output target recognizer info #1221

Closed
gabog opened this issue Apr 27, 2021 · 6 comments
Closed

bf luis:cross-train should output target recognizer info #1221

gabog opened this issue Apr 27, 2021 · 6 comments
Assignees
Labels
backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. feature-request A request for new functionality or an enhancement to an existing one. P2 Nice to have

Comments

@gabog
Copy link
Contributor

gabog commented Apr 27, 2021

Currently luis:cross-train crawls a given folder for lu and qna files and outputs the found files to another folder but it doesn't persist any information on what recognizer should be used to build, train and publish that file.

In some senarios, you can have a bot that have dialogs that use LUIS recognizers and dialogs that use an orchestrator recognizer. With the current output of luis:cross-train we can't tell if we need to call luis:build or orchestrator:build.

If this change is implemented, we will also need to modify luis:build and orchestrator:build to look at this information when crawling the files for training.

Note (5/11/2021): One possible solution would be for cross-train to generate luconfig files like I did for CI/CD, it should generate one config file for each recgonizer listing the LU models for each one of them.

@gabog gabog added needs-triage The issue has just been created and it has not been reviewed by the team. feature-request A request for new functionality or an enhancement to an existing one. labels Apr 27, 2021
@gabog gabog added this to the R14 milestone Apr 27, 2021
@gabog
Copy link
Contributor Author

gabog commented Apr 27, 2021

Hi @scheyal, ping me if you need more details, it would be good to address this in R14

@munozemilio munozemilio added P1 Painful if we don't fix, won't block releasing P2 Nice to have and removed P1 Painful if we don't fix, won't block releasing labels Jun 3, 2021
@scheyal
Copy link
Contributor

scheyal commented Jun 16, 2021

Status: consulting with Dong. Update soon.

@scheyal
Copy link
Contributor

scheyal commented Jun 18, 2021

Update: Scheduled a meeting w/ Dong & Gabo. Proposed that the fix should come by scanning the .dialog files (i.e. get it from the source, don't require repeat in another source).

@scheyal scheyal assigned boydc2014, scheyal and gabog and unassigned scheyal Jun 18, 2021
@scheyal
Copy link
Contributor

scheyal commented Jun 22, 2021

Meeting summary:

  • We will create new "discover" command in LUIS & Orchestrator BF CLI commands that will discover and produce listings of language assets in a way that would be consumable by the corresponding build commands.
  • @boydc2014 will follow up next.
  • This work will be scheduled for R15 since it can be risky, and we have an intermediate workaround.

@scheyal scheyal modified the milestones: R14, R15 Jun 22, 2021
@scheyal scheyal removed the needs-triage The issue has just been created and it has not been reviewed by the team. label Jun 22, 2021
@munozemilio
Copy link
Member

@boydc2014 is this still valid? will this be released in R15?

@munozemilio munozemilio removed this from the R15 milestone Sep 10, 2021
@munozemilio munozemilio added the backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. label Sep 10, 2021
@cosmicshuai
Copy link
Contributor

Maybe we can move it to R16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. feature-request A request for new functionality or an enhancement to an existing one. P2 Nice to have
Projects
None yet
Development

No branches or pull requests

6 participants