Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a more complete "driver" for the ResultParser(s) #114

Open
centis opened this issue Aug 22, 2019 · 0 comments
Open

Implement a more complete "driver" for the ResultParser(s) #114

centis opened this issue Aug 22, 2019 · 0 comments

Comments

@centis
Copy link

centis commented Aug 22, 2019

With the current implementation, any new results from DiskSpd must be added to both XmlResultsParse and ResultsParser. This is error-prone, and it seems there are instances where the output of the two is not consistent.

IResultParser is a good start, but it only implements a single top-level API. It would be better to implement a single ResultParser base class that drives the overall structure of the output and each derived class just adds/outputs values.

It might also be nice to change the suffix to "Generator" or something - it's not really a parser.
centis pushed a commit to centis/diskspd that referenced this issue Aug 22, 2019
Issue microsoft microsoft#113: Implement an option to allow DiskSpd t…
f43bcc6 
…o output higher precision results.

Issue microsoft#114: Implement a more complete "driver" for the ResultParser(s)

. Some local re-factoring to implement microsoft#113.  This is not a complete implementation, but a first step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@centis