You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the current implementation, any new results from DiskSpd must be added to both XmlResultsParse and ResultsParser. This is error-prone, and it seems there are instances where the output of the two is not consistent.
IResultParser is a good start, but it only implements a single top-level API. It would be better to implement a single ResultParser base class that drives the overall structure of the output and each derived class just adds/outputs values.
It might also be nice to change the suffix to "Generator" or something - it's not really a parser.
The text was updated successfully, but these errors were encountered:
centis
pushed a commit
to centis/diskspd
that referenced
this issue
Aug 22, 2019
…o output higher precision results.
Issue microsoft#114: Implement a more complete "driver" for the ResultParser(s)
. Some local re-factoring to implement microsoft#113. This is not a complete implementation, but a first step.
With the current implementation, any new results from DiskSpd must be added to both XmlResultsParse and ResultsParser. This is error-prone, and it seems there are instances where the output of the two is not consistent.
IResultParser is a good start, but it only implements a single top-level API. It would be better to implement a single ResultParser base class that drives the overall structure of the output and each derived class just adds/outputs values.
It might also be nice to change the suffix to "Generator" or something - it's not really a parser.
The text was updated successfully, but these errors were encountered: