Fix: Reset-AutomationSchedules incorrectly checking if provided time is at least one hour in the future (#1834)

Co-authored-by: msbrett <msbrett@users.no-reply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

src/optimization-engine/Reset-AutomationSchedules.ps1

@@ -77,21 +77,26 @@ else {
 $newBaseTimeStr = Read-Host "Please, enter a new base time for the *weekly* schedules in UTC (YYYY-MM-dd HH:mm:ss). If you want to keep the current one, just press ENTER"
 if (-not($newBaseTimeStr)) {
     $newBaseTimeStr = $baseTimeStr
+    $baseTimeOffset = [DateTimeOffset]::Parse($newBaseTimeStr)
 }
 else {
+    $minAllowedTime = [DateTimeOffset]::UtcNow.AddHours(1)
+
     try {
-        $newBaseTimeStr += "Z"
-        $newBaseTime = [DateTime]::Parse($newBaseTimeStr)
+        $baseTimeOffset = [DateTimeOffset]::Parse($newBaseTimeStr + "Z")
     }
     catch {
         throw "$newBaseTimeStr is an invalid base time. Use the following format: YYYY-MM-dd HH:mm:ss. For example: 1977-09-08 06:14:15"
     }
-    if ($newBaseTime -lt (Get-Date).ToUniversalTime().AddHours(-1)) {
-        throw "$newBaseTimeStr is an invalid base time. It can't be sooner than $((Get-Date).ToUniversalTime().AddHours(-1).ToString('u'))"
+
+    if ($baseTimeOffset -lt $minAllowedTime) {
+        throw "$($baseTimeOffset.ToString('u')) is an invalid base time. It must be at least 1 hour in the future (after $($minAllowedTime.ToString('u')))"
     }
+
+    $newBaseTimeStr = $baseTimeOffset.ToString("yyyy-MM-dd HH:mm:ss") + "Z"
 }
 
-$baseTimeUtc = [DateTime]::Parse($newBaseTimeStr).ToUniversalTime()
+$baseTimeUtc = $baseTimeOffset.UtcDateTime
 
 if ($newBaseTimeStr -ne $baseTimeStr) {
     Write-Host "Updating current base schedule to every $($baseTimeUtc.DayOfWeek) at $($baseTimeUtc.TimeOfDay.ToString()) UTC..." -ForegroundColor Green
@@ -205,4 +210,4 @@ else
     Write-Host "Kept current Hybrid Worker option: $hybridWorkerOption" -ForegroundColor Green
 }
 
-Write-Host "DONE" -ForegroundColor Green
+Write-Host "DONE" -ForegroundColor Green