Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AutoComplete does not display a red border when a validation error has occurred. #3407

Closed
StevenRasmussen opened this issue Feb 19, 2025 · 3 comments
Labels
closed:done Work is finished

Comments

@StevenRasmussen
Copy link
Contributor

🐛 Bug Report

When a validation error occurs on a FluentAutocomplete, there is no red outline that appears around the control similar to all the other controls.

💻 Repro or Code Sample

You can reproduce the issue on the demo site here: https://www.fluentui-blazor.net/Forms

Image

🤔 Expected Behavior

A red outline should surround the control

@microsoft-github-policy-service microsoft-github-policy-service bot added the triage New issue. Needs to be looked at label Feb 19, 2025
@vnbaaij vnbaaij added status:needs-investigation Needs additional investigation and removed triage New issue. Needs to be looked at labels Feb 19, 2025
@vnbaaij
Copy link
Collaborator

vnbaaij commented Feb 19, 2025

We had a message on the AutoComplete page that explained that the component is not yet fully compatible with
the EditForm and FluentEditForm elements. Some functionalities, such as error messages, the requirement message or the validation messages are missing. It is still showing the associated icon in the navigation menu. I'm adding back in the message for the next release.

Anyways, that doesn't work yet. Not sure when we'll get to it. We do take PR's...

@vnbaaij
Copy link
Collaborator

vnbaaij commented Feb 19, 2025

Image

@joriverm
Copy link
Contributor

joriverm commented Feb 20, 2025

i might change/PR this later if my current workload allows it, as i made the validations work. however, it seems i missed the CSS that applies the outline on controls when they are marked invalid. it should be applied to the text-area of the autocomplete.
they are marked as invalid, so its nothing code wise thankfully :)

@vnbaaij vnbaaij added closed:done Work is finished and removed status:needs-investigation Needs additional investigation labels Feb 20, 2025
@vnbaaij vnbaaij closed this as completed Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:done Work is finished
Projects
None yet
Development

No branches or pull requests

3 participants