Skip to content

[0011] Allow vk::ext_capability and vk::ext_extension on fields #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
s-perron opened this issue Jul 2, 2024 · 1 comment · Fixed by #270
Closed

[0011] Allow vk::ext_capability and vk::ext_extension on fields #269

s-perron opened this issue Jul 2, 2024 · 1 comment · Fixed by #270
Assignees
Labels
active proposal Issues relating to active proposals bug Something isn't working

Comments

@s-perron
Copy link
Collaborator

s-perron commented Jul 2, 2024

Which proposal does this relate to?

https://github.com/microsoft/hlsl-specs/blob/main/proposals/0011-inline-spirv.md

Describe the issue or outstanding question.

The documentation for these attributes say they can only be used on certain functions. This worked for types that required capability and extensions because types were declared using a function, which was awkward.

In proposal 0011, we replaced the original way of declaring a spir-v type with the type vk::SprivType and vk::SpirvOpaqueType. I just realized we have no way of adding the required extension and capabilities that they types many require because you do not necessarily have a function.

We should allow the vk::ext_capability and vk::ext_extension attributes on any variable declaration (global, function scope, and field) I don't know if parameters are needed. So that the appropriate capabilities and extensions can be added when vk::Spriv*Type is used.

@s-perron s-perron added the active proposal Issues relating to active proposals label Jul 2, 2024
@s-perron s-perron self-assigned this Jul 2, 2024
@s-perron s-perron added bug Something isn't working active proposal Issues relating to active proposals and removed active proposal Issues relating to active proposals labels Jul 2, 2024
@devshgraphicsprogramming

Even the current implementation from #270 has a bit of gap things slip through
microsoft/DirectXShaderCompiler#6958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
active proposal Issues relating to active proposals bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants