-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Kiota PHP repositories #156
Comments
Whenever this is completed we should also:
|
(Subject to future edits as investigation continues, but edits will be listed here) Composer (dependency manager) supports linking between sub-projects, however Packagist (dependency repository) doesn't support deployments from sub-packages. Packagist expects a package to be hosted within a GitHub repository whose root folder contains a composer.json file. Reference Currently, package deployment works like this, our PHP repos have a Packagist GitHub app set up & a webhook that triggers publishing to Packagist when a tag is created. The version of the packages is determined by the tag or adding a "version" property to the composer.json. With a mono-repo, our limitation would be in the deployment process. Various tools exist that split the mono-repo into repositories during deployment & pushes commits & tags to the new repos so that deployment happens. Two major tools seem viable for this: Mono-repo builderwhich provides various CLI utilities to validate our dependency versions across sub-projects & release automations which we shouldn't need courtesy of release-please. It does the repo split using a release workflow with the Splitsh-litewhich does only the repo subtree split and has been used by Google Cloud PHP mono-repo to deploy their various service libraries as separate packages ref. They augment this with their own custom scripts. Mono-repo builder seems most viable however it still leaves us potentially with our individual repositories for abstractions, http etc but we can manage everything via a kiota-php repository. Pending:
|
Open to further feedback here @andrueastman, @baywet, @shemogumbe |
Thank you for the additional information. So if I'm following things properly, in those scenarios we'd:
Or am I missing anything here? |
Yes, create a mono-repo. We could keep the current repos for the core libraries for to re-use the current Packagist webhook configs. |
Thanks! The two things I'd want us to get clarity on before we make any decision are:
|
Related to microsoft/kiota#4636 and microsoft/kiota-dotnet#238
As a language specific concern, we should look into the feasibility of grouping the repos and outline if this is not feasible in this issue.
The text was updated successfully, but these errors were encountered: