@microsoft/kiota-bundle versioning

[hognevevle]

Hello,

I'm a bit confused about the current @microsoft/kiota-bundle versioning.

Currently, kiota info -l typescript instructs me to install version 1.0.0-preview.11 of @microsoft/kiota-bundle.

kiota info -l typescript
The language TypeScript is currently in Preview maturity level.
After generating code for this language, you need to install the following packages:
Package Name                           Version           Type          
@microsoft/kiota-authentication-azure  1.0.0-preview.63  Authentication
@microsoft/kiota-bundle                1.0.0-preview.11  Bundle
[...]

The bundle package, however, has dependencies on * for all the different kiota-* packages.

kiota-typescript/packages/bundle/package.json

Lines 32 to 38 in 21c6421

	"dependencies": {
	"@microsoft/kiota-abstractions": "*",
	"@microsoft/kiota-http-fetchlibrary": "*",
	"@microsoft/kiota-serialization-form": "*",
	"@microsoft/kiota-serialization-json": "*",
	"@microsoft/kiota-serialization-multipart": "*",
	"@microsoft/kiota-serialization-text": "*"

This means that all of them will be installed with the latest version.

✗ yarn add @microsoft/[email protected]
➤ YN0000: · Yarn 4.3.1
➤ YN0000: ┌ Resolution step
➤ YN0085: │ + @microsoft/kiota-bundle@npm:1.0.0-preview.11, @microsoft/kiota-abstractions@npm:1.0.0-preview.70, @microsoft/kiota-http-fetchlibrary@npm:1.0.0-preview.70, @microsoft/kiota-serialization-form@npm:1.0.0-preview.70, @microsoft/kiota-serialization-json@npm:1.0.0-preview.70, and 5 more.
➤ YN0000: └ Completed in 2s 965ms

Is this the intended behaviour? How can I tell if those (.70) are the correct versions compatible with the code generated by kiota?

[andrueastman]

Thanks for raising this @hognevevle

Apologies for the confusion here. At the moment, running kiota info -l typescript will show the dependency list at the time of the release of the kiota version you are using (which would get outdated if a new version was released later on). This information are the versions compatible/validated with the kiota generator version you are using. On the next release of the Kiota this information should be updated to higher versions of the dependencies validated against the generator.

To also alleviate confusion here, going forward, versions for the Typescript libraries will be aligned to the same version as we also do for other languages like C#,java and python(see example release here). So, if you use the bundle version 1.0.0-preview.63 the other libraries e.g. serialization that are compatible with the version will be of the same version 1.0.0-preview.63.

Let us know if you have further questions.

[hognevevle]

Thanks for the clarification, @andrueastman !

I might be missing something, but won't the dependencies on * from the bundle package still cause problems here? I.e. whenever you install the bundle package (be it version preview.10 or preview.70), you will always get the latest version of the dependencies. Wouldn't it make sense for the bundle package to depend on specific versions as well? Or is this something you already plan on doing?

[baywet]

@hognevevle I do think you're correct since if you run the following

npm init -y
npm i @microsoft/kiota-bundle -S
cat node_modules/@microsoft/kiota-bundle/package.json

you get (for the dependencies section)

 "dependencies": {
                "@microsoft/kiota-abstractions": "*",
                "@microsoft/kiota-http-fetchlibrary": "*",
                "@microsoft/kiota-serialization-form": "*",
                "@microsoft/kiota-serialization-json": "*",
                "@microsoft/kiota-serialization-multipart": "*",
                "@microsoft/kiota-serialization-text": "*"
        },

I think we've operated under an assumption that lerna would replace the versions for us, which is not happening right now.
This can have serious side effects, and needs to be investigated. All the packages beyond kiota-abstractions are most likely impacted since this is how they refer to abstractions.

Solving this might also have a positive impact on #1369

[andrueastman]

Thanks for the clarification here. In that case, I believe we can set a version in the projects and release please will update the dependencies by updating the versions once we use the node-workspace plugin.

https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#node-workspace