Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter option in VS Code extension is not very useful #4678

Closed
darrelmiller opened this issue May 18, 2024 · 3 comments
Closed

Filter option in VS Code extension is not very useful #4678

darrelmiller opened this issue May 18, 2024 · 3 comments
Labels
Status: No Recent Activity status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close type:bug A broken experience

Comments

@darrelmiller
Copy link
Member

What are you generating using Kiota, clients or plugins?

API Client/SDK

In what context or format are you using Kiota?

Nuget tool

Client library/SDK language

None

Describe the bug

I'm trying to use the API Explorer to find an API operation that is of interest to me. e.g. I load the Microsoft Graph OpenAPI and filter on the phrase "sendmail" because I want to generate for that particular API. However, the filter also filters out the POST operation under "sendmail" so I cannot select it.
When I remove the sendmail filter so that I can see the POST operation for sendmail, the entire tree refreshes and I lose my place.

Expected behavior

I expect to be able to search for a segment and then somehow interact with the operations related to that segment. I see two possible solutions. Provide a way to clear the filter but keep the cursor on the currently selected node. The other solution might be to always show the nodes underneath the filtered node. I think I prefer the second solution because it allows me to focus on the subtree below the filtered node.

How to reproduce

In the description.

Open API description file

No response

Kiota Version

1.15.0-preview.202405160001+b242eafdf0eae4ac8063500a238ac1f2be1e2988

Latest Kiota version known to work for scenario above?(Not required)

No response

Known Workarounds

No response

Configuration

No response

Debug output

Click to expand log ```
</details>


### Other information

_No response_
@darrelmiller darrelmiller added type:bug A broken experience status:waiting-for-triage An issue that is yet to be reviewed or assigned labels May 18, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota May 18, 2024
@baywet
Copy link
Member

baywet commented May 20, 2024

@darrelmiller are you suggesting we always keep only the leaf nodes (operations) under what's filtered? or the whole branch?

@baywet baywet added the status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close label May 20, 2024
@baywet baywet added this to the Backlog milestone May 20, 2024
@baywet baywet moved this from Needs Triage 🔍 to Proposed 💡 in Kiota May 22, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@sebastienlevert sebastienlevert removed Status: No Recent Activity status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close labels May 24, 2024
@andrueastman andrueastman added status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close and removed status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Aug 6, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service microsoft-github-policy-service bot removed this from the Backlog milestone Aug 13, 2024
@github-project-automation github-project-automation bot moved this from Proposed 💡 to Done ✔️ in Kiota Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: No Recent Activity status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close type:bug A broken experience
Projects
Archived in project
Development

No branches or pull requests

4 participants