Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- fixes a bug where no content codes would be considered structured #4367

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Mar 20, 2024

fixes #4190

@baywet baywet requested a review from a team as a code owner March 20, 2024 18:20
@baywet baywet self-assigned this Mar 20, 2024
@baywet baywet enabled auto-merge March 20, 2024 18:20
Copy link

sonarcloud bot commented Mar 21, 2024

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baywet
Copy link
Member Author

baywet commented Mar 21, 2024

@andrueastman yes, thanks for the nudge, my plan was to create follow up issues in the http repos.
Effectively there are two major cases:

  • 3XX response with a location header: the redirect middleware will follow the location value, and return the other response. Should work as is.
  • 3XX response without a location header: we'll get the immediate response, and depending on what IsSuccessResponse (or equivalent) evaluates, we might throw when we shouldn't today. This should be fixed in the implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Kiota throws ApiException when server returns 304
2 participants