Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using full names of generated types to avoid ambiguities with existing namespaces #4751

Merged
merged 11 commits into from
Jun 4, 2024
Merged

Conversation

peterwurzinger
Copy link
Contributor

Fixes #4475 by using full names 1 to reference generated types, cc @baywet

Footnotes

  1. I'm using the term 'full name' instead of 'fully qualified name' as the FQN would include the assembly name name as well, and it is more consistent with https://learn.microsoft.com/en-us/dotnet/api/system.type.fullname?view=net-8.0

@peterwurzinger peterwurzinger requested a review from a team as a code owner May 31, 2024 20:11
@peterwurzinger
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution here @peterwurzinger

Any chance you can also add a changelog entry at the repo root?

It would also be great to create a PR for the samples at https://github.com/microsoft/kiota-samples/tree/main/msgraph-mail/dotnet so that the change can be paired with this PR.

@peterwurzinger
Copy link
Contributor Author

peterwurzinger commented Jun 3, 2024

Sure, yeah. I added a line to the changelog file to reflect the changes made. Also I covered the things you mentioned during the review, feel free to check again.

The only thing left is the PR for the samples. Did you mean using my local Kiota version including this fix to recreate the API client in https://github.com/microsoft/kiota-samples/tree/main/msgraph-mail/dotnet ? Because if that's the case, it would include new code from main, as it seems that sample hasn't been updated in a while. So if that's your intention, would that be what you asked for? If yes, I can surely submit is as a PR.

@andrueastman
Copy link
Member

So if that's your intention, would that be what you asked for? If yes, I can surely submit is as a PR.

Yes. Please submit that as a PR as well.

@andrueastman
Copy link
Member

Validated PR with https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=151761&view=results for beta/v1.0 graph metadata as well for dotnet and CLI builds

@andrueastman andrueastman merged commit c05fb25 into microsoft:main Jun 4, 2024
206 checks passed
@peterwurzinger peterwurzinger deleted the fix/4475 branch June 4, 2024 08:24
@baywet baywet mentioned this pull request Jun 11, 2024
0xced added a commit to 0xced/kiota that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C#] API model name conflicts with namespace
2 participants