-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using full names of generated types to avoid ambiguities with existing namespaces #4751
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution here @peterwurzinger
Any chance you can also add a changelog entry at the repo root?
It would also be great to create a PR for the samples at https://github.com/microsoft/kiota-samples/tree/main/msgraph-mail/dotnet so that the change can be paired with this PR.
…ode elements Co-authored-by: Andrew Omondi <[email protected]>
Sure, yeah. I added a line to the changelog file to reflect the changes made. Also I covered the things you mentioned during the review, feel free to check again. The only thing left is the PR for the samples. Did you mean using my local Kiota version including this fix to recreate the API client in https://github.com/microsoft/kiota-samples/tree/main/msgraph-mail/dotnet ? Because if that's the case, it would include new code from main, as it seems that sample hasn't been updated in a while. So if that's your intention, would that be what you asked for? If yes, I can surely submit is as a PR. |
Yes. Please submit that as a PR as well. |
Validated PR with https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=151761&view=results for beta/v1.0 graph metadata as well for dotnet and CLI builds |
This reverts commit c05fb25.
Fixes #4475 by using full names 1 to reference generated types, cc @baywet
Footnotes
I'm using the term 'full name' instead of 'fully qualified name' as the FQN would include the assembly name name as well, and it is more consistent with https://learn.microsoft.com/en-us/dotnet/api/system.type.fullname?view=net-8.0 ↩