Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python failing integration tests #5724

Merged
merged 13 commits into from
Nov 11, 2024
Merged

Fix python failing integration tests #5724

merged 13 commits into from
Nov 11, 2024

Conversation

shemogumbe
Copy link
Contributor

@shemogumbe shemogumbe commented Nov 4, 2024

Fixes #5637

@shemogumbe shemogumbe marked this pull request as ready for review November 4, 2024 15:53
@shemogumbe shemogumbe requested a review from a team as a code owner November 4, 2024 15:53
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing a changelog entry.
Could we also reenable the integration test that is fixed here as well by removing this entry?

"Rationale": "https://github.com/microsoft/kiota/issues/5637"

@shemogumbe shemogumbe marked this pull request as draft November 7, 2024 13:19
@shemogumbe shemogumbe changed the title rearrange imports to top of file Fix python failing integration tests Nov 9, 2024
@shemogumbe shemogumbe marked this pull request as ready for review November 9, 2024 10:26
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 11, 2024

CHANGELOG.md Outdated Show resolved Hide resolved
@baywet baywet merged commit 5922724 into main Nov 11, 2024
216 checks passed
@baywet baywet deleted the shem/fix_local_imports branch November 11, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

Python - local imports cause invalid serialization code
4 participants