Fixes invalid code in Php caused by /*/*` in property description
#5770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested changes
Nov 13, 2024
baywet
previously approved these changes
Nov 13, 2024
|
@timayabi2020 the integration tests are still failing because of a ; after removing the suppression, can you have a look into it please? |
…his accomodates values with apostrophe
baywet
previously approved these changes
Nov 14, 2024
|
Actually @timayabi2020 this unveiled another issue with string imports. https://github.com/microsoft/kiota/actions/runs/11835775961/job/32979477737?pr=5770 Can you have a look at that as well please? Capturing the defect issue and adding a suppression is also an acceptable outcome to get this PR merged. |
baywet
approved these changes
Nov 14, 2024
timayabi2020
deleted the
5635-php---doc-comments-with--lead-to-invalid-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5635
Property descriptions containing
/*/*causes malformed document in generated Php classes with properties and descriptions.