Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for base url #795

Merged
merged 9 commits into from
Nov 8, 2021
Merged

adds support for base url #795

merged 9 commits into from
Nov 8, 2021

Conversation

baywet
Copy link
Member

@baywet baywet commented Nov 5, 2021

Overview

Fixes #785

Generation diff

microsoft/kiota-samples#385

@baywet baywet added this to the TypeWriter Replacement milestone Nov 5, 2021
@baywet baywet added the generator Issues or improvements relater to generation capabilities. label Nov 5, 2021
@baywet baywet self-assigned this Nov 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes! 👍🏼

@baywet baywet disabled auto-merge November 8, 2021 12:28
@baywet baywet merged commit ace94e9 into main Nov 8, 2021
@baywet baywet deleted the feature/base-url branch November 8, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator Issues or improvements relater to generation capabilities. WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base Url should be a path parameter
2 participants