Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create simple threadpool for avoiding constant thread creation #115

Merged
merged 7 commits into from
Nov 20, 2024

Conversation

mcroomp
Copy link
Collaborator

@mcroomp mcroomp commented Nov 16, 2024

We're having some trouble with live site profiling since we're always creating threads. Reuse existing threads up to the number of CPUs. There's no upper limit to the number of threads to keep the behavior as similar as possible.

@Melirius
Copy link
Collaborator

Nice work! Will check tomorrow.

Copy link
Collaborator

@Melirius Melirius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and slightly faster as well.

@Melirius Melirius merged commit 5997f8c into main Nov 20, 2024
3 checks passed
@Melirius Melirius deleted the simplethreadpool2 branch November 20, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants