Skip to content

Commit

Permalink
Updates to address Semver value errors in verify_device_rss_hash_key_…
Browse files Browse the repository at this point in the history
…change (#3429)

* converting mimimum version to semver object before comparison

* Removing extra line to comply with Black
  • Loading branch information
umfranci authored Sep 20, 2024
1 parent 2f0d56f commit 406a649
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions microsoft/testsuites/network/networksettings.py
Original file line number Diff line number Diff line change
Expand Up @@ -368,15 +368,11 @@ def verify_device_rss_hash_key_change(self, node: Node, log: Logger) -> None:
uname = node.tools[Uname]
linux_info = uname.get_linux_information()

min_supported_kernel = linux_info.kernel_version
if isinstance(node.os, Debian) or isinstance(node.os, Redhat):
min_supported_kernel = "5.0.0"
min_supported_kernel = parse_version("5.0.0")
elif isinstance(node.os, Suse):
min_supported_kernel = "4.12.14"
else:
# For other OS, it is not known which minimum kernel version
# supports RSS Hash key change. This can be found and later
# enhanced after running tests.
min_supported_kernel = str(linux_info.kernel_version)
min_supported_kernel = parse_version("4.12.14")

if linux_info.kernel_version < min_supported_kernel:
raise SkippedException(
Expand Down

0 comments on commit 406a649

Please sign in to comment.